Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1977)

Unified Diff: Source/web/tests/TouchActionTest.cpp

Issue 270573008: Oilpan: Prepare to support garbage-collected Node in WebNode hierarchy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/TouchActionTest.cpp
diff --git a/Source/web/tests/TouchActionTest.cpp b/Source/web/tests/TouchActionTest.cpp
index 4d5e1a7a4833c0f03f694243bfac922ea0422acf..52d22af0fbe9091cfb3b496de42c79b6cb9fd7a2 100644
--- a/Source/web/tests/TouchActionTest.cpp
+++ b/Source/web/tests/TouchActionTest.cpp
@@ -133,7 +133,7 @@ void TouchActionTest::runTouchActionTest(std::string file)
WebView* webView = setupTest(file, client);
- RefPtr<WebCore::Document> document = static_cast<PassRefPtr<WebCore::Document> >(webView->mainFrame()->document());
+ RefPtrWillBeRawPtr<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
haraken 2014/05/08 06:22:37 Is the static_cast needed?
tkent 2014/05/08 07:39:30 Yes. webView->mainFrame()->document() is a WebDoc
runTestOnTree(document.get(), webView, client);
m_webViewHelper.reset(); // Explicitly reset to break dependency on locally scoped client.
@@ -146,7 +146,7 @@ void TouchActionTest::runShadowDOMTest(std::string file)
WebView* webView = setupTest(file, client);
WebCore::TrackExceptionState es;
- RefPtr<WebCore::Document> document = static_cast<PassRefPtr<WebCore::Document> >(webView->mainFrame()->document());
+ RefPtrWillBeRawPtr<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
haraken 2014/05/08 06:22:37 Ditto. The same comment for other static_casts in
RefPtr<WebCore::NodeList> hostNodes = document->querySelectorAll("[shadow-host]", es);
ASSERT_FALSE(es.hadException());
ASSERT_GE(hostNodes->length(), 1u);
@@ -173,7 +173,7 @@ WebView* TouchActionTest::setupTest(std::string file, TouchActionTrackingWebView
// Scroll to verify the code properly transforms windows to client co-ords.
const int kScrollOffset = 100;
- RefPtr<WebCore::Document> document = static_cast<PassRefPtr<WebCore::Document> >(webView->mainFrame()->document());
+ RefPtrWillBeRawPtr<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
haraken 2014/05/08 06:22:37 Ditto.
document->frame()->view()->setScrollOffset(WebCore::IntPoint(0, kScrollOffset));
return webView;

Powered by Google App Engine
This is Rietveld 408576698