Oilpan: Prepare to support garbage-collected Node in WebNode hierarchy.

Oilpan: Prepare to support garbage-collected Node in WebNode hierarchy.

That is to say, WebNode::m_private should be based on Persistent<Node>.
Because all of WebNode subclasses shares it, we need to change the
classes so that they can be convertible to RawPtr instead of PassRefPtr.

We need some #if ENABLE(OILPAN) because some WebCore functions
still return PassRefPtrs.


BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173622

[tkent, 2014-05-08 06:10:54]

Please review this.

[haraken, 2014-05-08 06:22:36]

LGTM.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebDocument.cpp
File Source/web/WebDocument.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebDocument.cpp#n...
Source/web/WebDocument.cpp:257: #if ENABLE(OILPAN)

This can be removed once we make createElement return a PassRefPtrWillBeRawPtr.
Add a FIXME.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebFormElement.cpp
File Source/web/WebFormElement.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebFormElement.cp...
Source/web/WebFormElement.cpp:83: #if !ENABLE(OILPAN)

#if ENABLE(OILPAN)
#else
#endif

would be better.

Also add a FIXME that this should be removed once we change |tempVector| to
WillBeHeapVector<RefPtrWillBeMember<Element>>.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebNode.cpp
File Source/web/WebNode.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebNode.cpp#newco...
Source/web/WebNode.cpp:208: #if ENABLE(OILPAN)

This can be removed once we make querySelector return PassRefPtrWillBeRawPtr.
Add a FIXME.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebSearchableForm...
File Source/web/WebSearchableFormData.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebSearchableForm...
Source/web/WebSearchableFormData.cpp:239: HTMLInputElement* inputElement =
static_cast<PassRefPtrWillBeRawPtr<HTMLInputElement>
>(selectedInputElement).get();

Can we avoid using static_cast by adding some implicit conversion?

https://codereview.chromium.org/270573008/diff/1/Source/web/tests/TouchAction...
File Source/web/tests/TouchActionTest.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/tests/TouchAction...
Source/web/tests/TouchActionTest.cpp:136: RefPtrWillBeRawPtr<WebCore::Document>
document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document>
>(webView->mainFrame()->document());

Is the static_cast needed?

https://codereview.chromium.org/270573008/diff/1/Source/web/tests/TouchAction...
Source/web/tests/TouchActionTest.cpp:149: RefPtrWillBeRawPtr<WebCore::Document>
document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document>
>(webView->mainFrame()->document());

Ditto. The same comment for other static_casts in this CL.

https://codereview.chromium.org/270573008/diff/1/Source/web/tests/TouchAction...
Source/web/tests/TouchActionTest.cpp:176: RefPtrWillBeRawPtr<WebCore::Document>
document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document>
>(webView->mainFrame()->document());

Ditto.

[wibling-chromium, 2014-05-08 07:07:01]

lgtm

https://codereview.chromium.org/270573008/diff/1/Source/web/WebFormElement.cpp
File Source/web/WebFormElement.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebFormElement.cp...
Source/web/WebFormElement.cpp:86: Vector<WebNode> tempVector2;
Just to make sure i understand. This extra copy is only needed until we change
HTMLFormElement's getNamedLElements to return a Vector<RefPtrWillBeRawPtr<Node>?
If so could we add a FIXME?

[Mads Ager (chromium), 2014-05-08 07:27:35]

lgtm2

https://codereview.chromium.org/270573008/diff/1/public/platform/WebPrivatePtr.h
File public/platform/WebPrivatePtr.h (left):

https://codereview.chromium.org/270573008/diff/1/public/platform/WebPrivatePt...
public/platform/WebPrivatePtr.h:56: typedef char TreeSharedType;
Thanks! I should have removed this when I removed TreeShared from the oilpan
build. :)

[tkent, 2014-05-08 07:39:30]

https://codereview.chromium.org/270573008/diff/1/Source/web/WebDocument.cpp
File Source/web/WebDocument.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebDocument.cpp#n...
Source/web/WebDocument.cpp:257: #if ENABLE(OILPAN)
On 2014/05/08 06:22:37, haraken wrote:
> 
> This can be removed once we make createElement return a
PassRefPtrWillBeRawPtr.
> Add a FIXME.

Done.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebFormElement.cpp
File Source/web/WebFormElement.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebFormElement.cp...
Source/web/WebFormElement.cpp:83: #if !ENABLE(OILPAN)
On 2014/05/08 06:22:37, haraken wrote:
> 
> #if ENABLE(OILPAN)
> #else
> #endif
> 
> would be better.
> 
> Also add a FIXME that this should be removed once we change |tempVector| to
> WillBeHeapVector<RefPtrWillBeMember<Element>>.

Done.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebFormElement.cp...
Source/web/WebFormElement.cpp:86: Vector<WebNode> tempVector2;
On 2014/05/08 07:07:01, wibling-chromium wrote:
> Just to make sure i understand. This extra copy is only needed until we change
> HTMLFormElement's getNamedLElements to return a
Vector<RefPtrWillBeRawPtr<Node>?
> If so could we add a FIXME?

Right.  We can remove the extra copy later.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebNode.cpp
File Source/web/WebNode.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebNode.cpp#newco...
Source/web/WebNode.cpp:208: #if ENABLE(OILPAN)
On 2014/05/08 06:22:37, haraken wrote:
> 
> This can be removed once we make querySelector return PassRefPtrWillBeRawPtr.
> Add a FIXME.

Done.

https://codereview.chromium.org/270573008/diff/1/Source/web/WebSearchableForm...
File Source/web/WebSearchableFormData.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/WebSearchableForm...
Source/web/WebSearchableFormData.cpp:239: HTMLInputElement* inputElement =
static_cast<PassRefPtrWillBeRawPtr<HTMLInputElement>
>(selectedInputElement).get();
On 2014/05/08 06:22:37, haraken wrote:
> 
> Can we avoid using static_cast by adding some implicit conversion?

I don't think we should do anything in this CL to avoid static_casts.

|coreObject = static_cast<PassRefPtr<T>>(webObject)| is our current idiom to get
a WebCore object from a corresponding WebFoo object.
As for the change of this file, I also fixed weird usages of cast operators.

https://codereview.chromium.org/270573008/diff/1/Source/web/tests/TouchAction...
File Source/web/tests/TouchActionTest.cpp (right):

https://codereview.chromium.org/270573008/diff/1/Source/web/tests/TouchAction...
Source/web/tests/TouchActionTest.cpp:136: RefPtrWillBeRawPtr<WebCore::Document>
document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document>
>(webView->mainFrame()->document());
On 2014/05/08 06:22:37, haraken wrote:
> 
> Is the static_cast needed?

Yes.  webView->mainFrame()->document() is a WebDocument.

[tkent, 2014-05-08 07:47:17]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-05-08 07:48:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/270573008/20001

[commit-bot: I haz the power, 2014-05-08 09:02:43]

Change committed as 173622