Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: Source/bindings/scripts/compute_interfaces_info.py

Issue 270573005: Move modules-dependent IDL statements out of core by supporting 'implements' in RHS interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed reviewer comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/utilities.py » ('j') | Source/bindings/scripts/utilities.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/compute_interfaces_info.py
diff --git a/Source/bindings/scripts/compute_interfaces_info.py b/Source/bindings/scripts/compute_interfaces_info.py
index 82c236cebf9e458f3d514024effa1c3454848389..2333f5c1ff2559314b3dcab6d4a811962d7097cb 100755
--- a/Source/bindings/scripts/compute_interfaces_info.py
+++ b/Source/bindings/scripts/compute_interfaces_info.py
@@ -82,7 +82,7 @@ import os
import posixpath
import sys
-from utilities import get_file_contents, write_pickle_file, get_interface_extended_attributes_from_idl, is_callback_interface_from_idl, get_partial_interface_name_from_idl, get_implemented_interfaces_from_idl, get_parent_interface, get_put_forward_interfaces_from_idl
+from utilities import get_file_contents, write_pickle_file, get_interface_extended_attributes_from_idl, is_callback_interface_from_idl, get_partial_interface_name_from_idl, get_implements_from_idl, get_parent_interface, get_put_forward_interfaces_from_idl
module_path = os.path.dirname(__file__)
source_path = os.path.normpath(os.path.join(module_path, os.pardir, os.pardir))
@@ -173,10 +173,12 @@ def compute_individual_info(idl_filename):
# If not a partial interface, the basename is the interface name
interface_name, _ = os.path.splitext(os.path.basename(idl_filename))
+ left_interfaces, right_interfaces = get_implements_from_idl(idl_file_contents, interface_name)
+
interfaces_info[interface_name] = {
'full_path': full_path,
'implemented_as': implemented_as,
- 'implements_interfaces': get_implemented_interfaces_from_idl(idl_file_contents, interface_name),
+ 'implements_interfaces': right_interfaces,
'include_path': this_include_path,
# FIXME: temporary private field, while removing old treatement of
# 'implements': http://crbug.com/360435
@@ -191,6 +193,10 @@ def compute_individual_info(idl_filename):
'referenced_interfaces': get_put_forward_interfaces_from_idl(idl_file_contents),
}
+ for left_interface_name in left_interfaces:
+ interface_info = interfaces_info[left_interface_name]
+ interface_info['implements_interfaces'].append(interface_name)
+
# Record inheritance information
inherited_extended_attributes_by_interface[interface_name] = dict(
(key, value)
« no previous file with comments | « no previous file | Source/bindings/scripts/utilities.py » ('j') | Source/bindings/scripts/utilities.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698