Move modules-dependent IDL statements out of core by supporting 'implements' in RHS interface

Source/bindings/scripts/compute_interfaces_info.py

 #!/usr/bin/python
 #
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 64 matching lines @@
 
 Design doc: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 from collections import defaultdict
 import optparse
 import os
 import posixpath
 import sys
 
-from utilities import get_file_contents, write_pickle_file, get_interface_extended_attributes_from_idl, is_callback_interface_from_idl, get_partial_interface_name_from_idl, get_implemented_interfaces_from_idl, get_parent_interface, get_put_forward_interfaces_from_idl
+from utilities import get_file_contents, write_pickle_file, get_interface_extended_attributes_from_idl, is_callback_interface_from_idl, get_partial_interface_name_from_idl, get_right_or_left_interfaces_of_implements_from_idl, get_parent_interface, get_put_forward_interfaces_from_idl
 
 module_path = os.path.dirname(__file__)
 source_path = os.path.normpath(os.path.join(module_path, os.pardir, os.pardir))
 
 INHERITED_EXTENDED_ATTRIBUTES = set([
     'ActiveDOMObject',
     'DependentLifetime',
     'GarbageCollected',
     'WillBeGarbageCollected',
 ])
@@ skipping 69 matching lines @@
     this_include_path = include_path(idl_filename, implemented_as)
 
     # Handle partial interfaces
     partial_interface_name = get_partial_interface_name_from_idl(idl_file_contents)
     if partial_interface_name:
         add_paths_to_partials_dict(partial_interface_name, full_path, this_include_path)
         return
 
     # If not a partial interface, the basename is the interface name
     interface_name, _ = os.path.splitext(os.path.basename(idl_filename))
 

[Inactive, 2014/05/07 21:10:09]

how about something like:
implements_statements = get_implements_from_idl(idl_file_content,
interface_name)
// implements_statements could be a list of 2-element tuples.

[c.shu, 2014/05/07 21:42:00]

Done.

     interfaces_info[interface_name] = {
         'full_path': full_path,
         'implemented_as': implemented_as,
-        'implements_interfaces': get_implemented_interfaces_from_idl(idl_file_contents, interface_name),
+        'implements_interfaces': get_right_or_left_interfaces_of_implements_from_idl(idl_file_contents, interface_name, True),

[Inactive, 2014/05/07 21:10:09]

[v[1] for v in implements_statements]

[c.shu, 2014/05/07 21:42:00]

Done.

         'include_path': this_include_path,
         # FIXME: temporary private field, while removing old treatement of
         # 'implements': http://crbug.com/360435
         'is_legacy_treat_as_partial_interface': 'LegacyTreatAsPartialInterface' in extended_attributes,
         'is_callback_interface': is_callback_interface_from_idl(idl_file_contents),
         # Interfaces that are referenced (used as types) and that we introspect
         # during code generation (beyond interface-level data ([ImplementedAs],
         # is_callback_interface, ancestors, and inherited extended attributes):
         # deep dependencies.
         # These cause rebuilds of referrers, due to the dependency, so these
         # should be minimized; currently only targets of [PutForwards].
         'referenced_interfaces': get_put_forward_interfaces_from_idl(idl_file_contents),
     }
 
+    left_implements_interfaces = get_right_or_left_interfaces_of_implements_from_idl(idl_file_contents, interface_name, False)

[Inactive, 2014/05/07 21:10:09]

Gosh, terribly long function name and an obscure boolean argument :(

left_implements_interfaces = [v[0] for v in implements_statements] ?

[c.shu, 2014/05/07 21:42:00]

Done.

+    for left_interface_name in left_implements_interfaces:
+        interface_info = interfaces_info[left_interface_name]
+        interface_info['implements_interfaces'].append(interface_name)
+
     # Record inheritance information
     inherited_extended_attributes_by_interface[interface_name] = dict(
             (key, value)
             for key, value in extended_attributes.iteritems()
             if key in INHERITED_EXTENDED_ATTRIBUTES)
     parent = get_parent_interface(idl_file_contents)
     if parent:
         parent_interfaces[interface_name] = parent
 
 
@@ skipping 93 matching lines @@
     idl_files.extend(args)
 
     compute_interfaces_info(idl_files)
     write_pickle_file(options.interfaces_info_file,
                       interfaces_info,
                       options.write_file_only_if_changed)
 
 
 if __name__ == '__main__':
     sys.exit(main())