Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 270573003: Rename NewFunction without prototype to NewFunctionWithoutPrototype (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Rename NewFunction without prototype to NewFunctionWithoutPrototype BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21241

Patch Set 1 #

Patch Set 2 : Reverse argument order to be consistent #

Total comments: 4

Patch Set 3 : Addressed comments #

Patch Set 4 : Don't deref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -73 lines) Patch
M src/bootstrapper.cc View 1 2 10 chunks +17 lines, -14 lines 0 comments Download
M src/factory.h View 1 2 4 chunks +30 lines, -24 lines 0 comments Download
M src/factory.cc View 1 2 3 7 chunks +47 lines, -34 lines 0 comments Download
M src/runtime.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 7 months ago (2014-05-07 12:01:15 UTC) #1
Benedikt Meurer
LGTM
6 years, 7 months ago (2014-05-07 12:04:06 UTC) #2
Igor Sheludko
lgtm with suggestion: https://codereview.chromium.org/270573003/diff/20001/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/270573003/diff/20001/src/factory.cc#newcode1206 src/factory.cc:1206: Handle<SharedFunctionInfo> info) { I think you ...
6 years, 7 months ago (2014-05-08 09:51:40 UTC) #3
Igor Sheludko
lgtm
6 years, 7 months ago (2014-05-09 17:39:12 UTC) #4
Toon Verwaest
6 years, 7 months ago (2014-05-09 17:40:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r21241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698