Make the OmniboxNavigationObserver update the ShortcutsProvider.

chrome/browser/history/shortcuts_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/shortcuts_backend.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 142 matching lines @@
   if (!suppress_db) {
     db_ = new ShortcutsDatabase(
         profile->GetPath().Append(chrome::kShortcutsDatabaseName));
   }
   // |profile| can be NULL in tests.
   if (profile) {
     notification_registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
                                 content::Source<Profile>(profile));
     notification_registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_DELETED,
                                 content::Source<Profile>(profile));
-    notification_registrar_.Add(this, chrome::NOTIFICATION_OMNIBOX_OPENED_URL,
-                                content::Source<Profile>(profile));
   }
 }
 
 bool ShortcutsBackend::Init() {
   if (current_state_ != NOT_INITIALIZED)
     return false;
 
   if (no_db_access_) {
     current_state_ = INITIALIZED;
     return true;
   }
 
   current_state_ = INITIALIZING;
   return BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
       base::Bind(&ShortcutsBackend::InitInternal, this));
 }
 
 bool ShortcutsBackend::DeleteShortcutsWithUrl(const GURL& shortcut_url) {
   return initialized() && DeleteShortcutsWithUrl(shortcut_url, true);
 }
 
 void ShortcutsBackend::AddObserver(ShortcutsBackendObserver* obs) {
   observer_list_.AddObserver(obs);
 }
 
 void ShortcutsBackend::RemoveObserver(ShortcutsBackendObserver* obs) {
   observer_list_.RemoveObserver(obs);
 }
 
+void ShortcutsBackend::OnOmniboxNavigation(const string16& text,
+                                           const AutocompleteMatch& match) {
+  const string16 text_lowercase(base::i18n::ToLower(text));
+  const base::Time now(base::Time::Now());
+  for (ShortcutMap::const_iterator it(
+       shortcuts_map_.lower_bound(text_lowercase));
+       it != shortcuts_map_.end() &&
+           StartsWith(it->first, text_lowercase, true); ++it) {
+    if (match.destination_url == it->second.match_core.destination_url) {
+      UpdateShortcut(Shortcut(it->second.id, text, Shortcut::MatchCore(match),
+                              now, it->second.number_of_hits + 1));
+      return;
+    }
+  }
+  AddShortcut(Shortcut(base::GenerateGUID(), text, Shortcut::MatchCore(match),
+                       now, 1));
+}
+
 ShortcutsBackend::~ShortcutsBackend() {
 }
 
 void ShortcutsBackend::ShutdownOnUIThread() {
   DCHECK(!BrowserThread::IsThreadInitialized(BrowserThread::UI) ||
          BrowserThread::CurrentlyOn(BrowserThread::UI));
   notification_registrar_.RemoveAll();
 }
 
 void ShortcutsBackend::Observe(int type,
                                const content::NotificationSource& source,
                                const content::NotificationDetails& details) {
   if (!initialized())
     return;
 
   if (type == chrome::NOTIFICATION_EXTENSION_UNLOADED) {
     // When an extension is unloaded, we want to remove any Shortcuts associated
     // with it.
     DeleteShortcutsWithUrl(content::Details<extensions::UnloadedExtensionInfo>(
         details)->extension->url(), false);
     return;
   }
 
-  if (type == chrome::NOTIFICATION_HISTORY_URLS_DELETED) {
-    if (content::Details<const history::URLsDeletedDetails>(details)->
-            all_history) {
-      DeleteAllShortcuts();
-    }
-    const URLRows& rows(
-        content::Details<const history::URLsDeletedDetails>(details)->rows);
-    std::vector<std::string> shortcut_ids;
+  DCHECK_EQ(chrome::NOTIFICATION_HISTORY_URLS_DELETED, type);
+  const history::URLsDeletedDetails* deleted_details =
+      content::Details<const history::URLsDeletedDetails>(details).ptr();
+  if (deleted_details->all_history)
+    DeleteAllShortcuts();
+  const URLRows& rows(deleted_details->rows);
+  std::vector<std::string> shortcut_ids;
 
-    for (GuidMap::const_iterator it(guid_map_.begin()); it != guid_map_.end();
-         ++it) {
-      if (std::find_if(
-          rows.begin(), rows.end(), URLRow::URLRowHasURL(
-              it->second->second.match_core.destination_url)) != rows.end())
-        shortcut_ids.push_back(it->first);
-    }
-    DeleteShortcutsWithIds(shortcut_ids);
-    return;
+  for (GuidMap::const_iterator it(guid_map_.begin()); it != guid_map_.end();
+        ++it) {
+    if (std::find_if(
+        rows.begin(), rows.end(), URLRow::URLRowHasURL(
+            it->second->second.match_core.destination_url)) != rows.end())
+      shortcut_ids.push_back(it->first);
   }
-
-  DCHECK(type == chrome::NOTIFICATION_OMNIBOX_OPENED_URL);
-
-  OmniboxLog* log = content::Details<OmniboxLog>(details).ptr();
-  string16 text_lowercase(base::i18n::ToLower(log->text));
-
-  const AutocompleteMatch& match(log->result.match_at(log->selected_index));
-  for (ShortcutMap::const_iterator it(
-       shortcuts_map_.lower_bound(text_lowercase));
-       it != shortcuts_map_.end() &&
-           StartsWith(it->first, text_lowercase, true); ++it) {
-    if (match.destination_url == it->second.match_core.destination_url) {
-      UpdateShortcut(Shortcut(it->second.id, log->text,
-                              Shortcut::MatchCore(match), base::Time::Now(),
-                              it->second.number_of_hits + 1));
-      return;
-    }
-  }
-  AddShortcut(Shortcut(base::GenerateGUID(), log->text,
-                       Shortcut::MatchCore(match), base::Time::Now(), 1));
+  DeleteShortcutsWithIds(shortcut_ids);
 }
 
 void ShortcutsBackend::InitInternal() {
   DCHECK(current_state_ == INITIALIZING);
   db_->Init();
   ShortcutsDatabase::GuidToShortcutMap shortcuts;
   db_->LoadShortcuts(&shortcuts);
   temp_shortcuts_map_.reset(new ShortcutMap);
   temp_guid_map_.reset(new GuidMap);
   for (ShortcutsDatabase::GuidToShortcutMap::const_iterator it(
@@ skipping 93 matching lines @@
   shortcuts_map_.clear();
   guid_map_.clear();
   FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
                     OnShortcutsChanged());
   return no_db_access_ || BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&ShortcutsDatabase::DeleteAllShortcuts),
                  db_.get()));
 }
 
 }  // namespace history