Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: experimental/PdfViewer/SkTrackDevice.h

Issue 27057003: pdfviewer: more code comments + concat the pdf matrix with the existing matrix in canvas, instead o… (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/PdfViewer/SkPdfUtils.h ('k') | experimental/PdfViewer/SkTracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkTrackDevice.h
===================================================================
--- experimental/PdfViewer/SkTrackDevice.h (revision 11730)
+++ experimental/PdfViewer/SkTrackDevice.h (working copy)
@@ -16,6 +16,11 @@
* A Track Device is used to track that callstack of an operation that affected some pixels.
* It can be used with SampleApp to investigate bugs (CL not checked in yet).
*
+ * every drawFoo is implemented as such:
+ * before(); // - collects state of interesting pixels
+ * INHERITED::drawFoo(...);
+ * after(); // - checks if pixels of interest, and issue a breakpoint.
+ *
*/
class SkTrackDevice : public SkBitmapDevice {
public:
@@ -39,6 +44,8 @@
virtual ~SkTrackDevice() {}
+ // Install a tracker - we can reuse the tracker between multiple devices, and the state of the
+ // tracker is preserved - number and location of poinbts, ...
void installTracker(SkTracker* tracker) {
fTracker = tracker;
fTracker->newFrame();
« no previous file with comments | « experimental/PdfViewer/SkPdfUtils.h ('k') | experimental/PdfViewer/SkTracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698