Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: experimental/PdfViewer/SkPdfReporter.cpp

Issue 27057003: pdfviewer: more code comments + concat the pdf matrix with the existing matrix in canvas, instead o… (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/PdfViewer/SkPdfReporter.h ('k') | experimental/PdfViewer/SkPdfUtils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkPdfReporter.cpp
===================================================================
--- experimental/PdfViewer/SkPdfReporter.cpp (revision 11730)
+++ experimental/PdfViewer/SkPdfReporter.cpp (working copy)
@@ -28,7 +28,11 @@
}
// TODO(edisonn): add a flag to set the minimum warning level
+// TODO(edisonn): get the address in the file, and report it.
+// TODO(edisonn): build a html file based on warnings which would showe the original pdf
+// content, with tooltips where warnings/errors were reported.
+
#ifdef PDF_REPORT
void SkPdfReport(SkPdfIssueSeverity sev, SkPdfIssue issue,
const char* context,
« no previous file with comments | « experimental/PdfViewer/SkPdfReporter.h ('k') | experimental/PdfViewer/SkPdfUtils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698