Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: ios/web/web_state/ui/crw_web_controller_unittest.mm

Issue 2705673003: Removed CRWSessionEntry from CRWWebController. (Closed)
Patch Set: reintroduced delegate callback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | ios/web/web_state/web_state_impl.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller_unittest.mm
diff --git a/ios/web/web_state/ui/crw_web_controller_unittest.mm b/ios/web/web_state/ui/crw_web_controller_unittest.mm
index 067be0f23a66afd080f9bcfc67687b95e86c41cc..b8ff6d05a0532dadc2cc8d86d589499af329a5ad 100644
--- a/ios/web/web_state/ui/crw_web_controller_unittest.mm
+++ b/ios/web/web_state/ui/crw_web_controller_unittest.mm
@@ -14,7 +14,6 @@
#import "base/test/ios/wait_util.h"
#import "ios/testing/ocmock_complex_type_helper.h"
#import "ios/web/navigation/crw_session_controller.h"
-#import "ios/web/navigation/crw_session_entry.h"
#import "ios/web/navigation/navigation_item_impl.h"
#import "ios/web/navigation/navigation_manager_impl.h"
#include "ios/web/public/referrer.h"
@@ -657,13 +656,11 @@ void TearDown() override {
NavigationManagerImpl& nav_manager =
web_controller().webStateImpl->GetNavigationManagerImpl();
CRWSessionController* session_controller = nav_manager.GetSessionController();
- EXPECT_EQ(2U, session_controller.entries.count);
- EXPECT_NSEQ(session_controller.entries.lastObject,
- session_controller.currentEntry);
+ EXPECT_EQ(2U, session_controller.items.size());
+ EXPECT_EQ(session_controller.items.back(), session_controller.currentItem);
[web_controller() goToItemAtIndex:0];
- EXPECT_NSEQ(session_controller.entries.firstObject,
- session_controller.currentEntry);
+ EXPECT_EQ(session_controller.items.front(), session_controller.currentItem);
}
// Tests that didShowPasswordInputOnHTTP updates the SSLStatus to indicate that
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | ios/web/web_state/web_state_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698