Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/chromeos/login/session_login_browsertest.cc

Issue 270563002: Componentize LoginManagerTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/session/session_state_delegate.h" 5 #include "ash/session/session_state_delegate.h"
6 #include "ash/shell.h" 6 #include "ash/shell.h"
7 #include "chrome/browser/chromeos/login/login_manager_test.h" 7 #include "chrome/browser/chromeos/login/login_manager_test_helper.h"
8 #include "chrome/browser/chromeos/login/startup_utils.h" 8 #include "chrome/browser/chromeos/login/startup_utils.h"
9 #include "chrome/browser/profiles/profile_manager.h" 9 #include "chrome/browser/profiles/profile_manager.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_finder.h" 11 #include "chrome/browser/ui/browser_finder.h"
12 #include "chrome/browser/ui/browser_window.h" 12 #include "chrome/browser/ui/browser_window.h"
13 #include "chrome/browser/ui/view_ids.h" 13 #include "chrome/browser/ui/view_ids.h"
14 #include "chrome/common/chrome_switches.h" 14 #include "chrome/common/chrome_switches.h"
15 #include "chrome/test/base/in_process_browser_test.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 #include "ui/views/focus/focus_manager.h" 17 #include "ui/views/focus/focus_manager.h"
17 #include "ui/views/view.h" 18 #include "ui/views/view.h"
18 19
19 namespace chromeos { 20 namespace chromeos {
20 21
21 namespace { 22 namespace {
22 23
23 const char kTestUser[] = "test-user@gmail.com"; 24 const char kTestUser[] = "test-user@gmail.com";
24 25
25 } // anonymous namespace 26 } // anonymous namespace
26 27
27 class BrowserLoginTest : public chromeos::LoginManagerTest { 28 class BrowserLoginTest : public InProcessBrowserTest {
28 public: 29 public:
29 BrowserLoginTest() : LoginManagerTest(true) {} 30 BrowserLoginTest()
31 : login_manager_test_helper_(new LoginManagerTestHelper(true)) {
32 set_exit_when_last_browser_closes(false);
33 }
34
30 virtual ~BrowserLoginTest() {} 35 virtual ~BrowserLoginTest() {}
31 36
37 virtual void SetUpOnMainThread() OVERRIDE {
38 login_manager_test_helper_->SetUp();
39 }
40
32 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { 41 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
33 LoginManagerTest::SetUpCommandLine(command_line); 42 login_manager_test_helper_->SetUpCommandLine(command_line);
34 command_line->AppendSwitch(::switches::kCreateBrowserOnStartupForTests); 43 command_line->AppendSwitch(::switches::kCreateBrowserOnStartupForTests);
35 } 44 }
45
46 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
47 login_manager_test_helper_->SetUpLoginUtils();
48 }
49
50 virtual void CleanUpOnMainThread() OVERRIDE {
51 login_manager_test_helper_->CleanUp();
52 }
53
54 protected:
55 scoped_ptr<LoginManagerTestHelper> login_manager_test_helper_;
36 }; 56 };
37 57
38 IN_PROC_BROWSER_TEST_F(BrowserLoginTest, PRE_BrowserActive) { 58 IN_PROC_BROWSER_TEST_F(BrowserLoginTest, PRE_BrowserActive) {
39 RegisterUser(kTestUser); 59 login_manager_test_helper_->RegisterUser(kTestUser);
40 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_PRIMARY, 60 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_PRIMARY,
41 ash::Shell::GetInstance()->session_state_delegate()-> 61 ash::Shell::GetInstance()->session_state_delegate()->
42 GetSessionState()); 62 GetSessionState());
43 chromeos::StartupUtils::MarkOobeCompleted(); 63 chromeos::StartupUtils::MarkOobeCompleted();
44 } 64 }
45 65
46 IN_PROC_BROWSER_TEST_F(BrowserLoginTest, BrowserActive) { 66 IN_PROC_BROWSER_TEST_F(BrowserLoginTest, BrowserActive) {
47 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_PRIMARY, 67 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_PRIMARY,
48 ash::Shell::GetInstance()->session_state_delegate()-> 68 ash::Shell::GetInstance()->session_state_delegate()->
49 GetSessionState()); 69 GetSessionState());
50 LoginUser(kTestUser); 70 login_manager_test_helper_->LogInUser(kTestUser);
51 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_ACTIVE, 71 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_ACTIVE,
52 ash::Shell::GetInstance()->session_state_delegate()-> 72 ash::Shell::GetInstance()->session_state_delegate()->
53 GetSessionState()); 73 GetSessionState());
54 74
55 Browser* browser = FindAnyBrowser(ProfileManager::GetActiveUserProfile(), 75 Browser* browser = FindAnyBrowser(ProfileManager::GetActiveUserProfile(),
56 false, 76 false,
57 chrome::HOST_DESKTOP_TYPE_ASH); 77 chrome::HOST_DESKTOP_TYPE_ASH);
58 EXPECT_TRUE(browser != NULL); 78 EXPECT_TRUE(browser != NULL);
59 EXPECT_TRUE(browser->window()->IsActive()); 79 EXPECT_TRUE(browser->window()->IsActive());
60 80
61 views::FocusManager* focus_manager = browser->window()-> 81 views::FocusManager* focus_manager = browser->window()->
62 GetBrowserWindowTesting()->GetTabContentsContainerView()-> 82 GetBrowserWindowTesting()->GetTabContentsContainerView()->
63 GetFocusManager(); 83 GetFocusManager();
64 EXPECT_TRUE(focus_manager != NULL); 84 EXPECT_TRUE(focus_manager != NULL);
65 85
66 const views::View* focused_view = focus_manager->GetFocusedView(); 86 const views::View* focused_view = focus_manager->GetFocusedView();
67 EXPECT_TRUE(focused_view != NULL); 87 EXPECT_TRUE(focused_view != NULL);
68 EXPECT_EQ(VIEW_ID_OMNIBOX, focused_view->id()); 88 EXPECT_EQ(VIEW_ID_OMNIBOX, focused_view->id());
69 } 89 }
70 90
71 } // namespace chromeos 91 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698