Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/chromeos/login/login_manager_test_helper.cc

Issue 270563002: Componentize LoginManagerTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/login_manager_test.h" 5 #include "chrome/browser/chromeos/login/login_manager_test_helper.h"
6 6
7 #include "base/prefs/scoped_user_pref_update.h" 7 #include "base/prefs/scoped_user_pref_update.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/chrome_notification_types.h" 9 #include "chrome/browser/chrome_notification_types.h"
10 #include "chrome/browser/chromeos/login/existing_user_controller.h" 10 #include "chrome/browser/chromeos/login/existing_user_controller.h"
11 #include "chrome/browser/chromeos/login/login_display_host_impl.h" 11 #include "chrome/browser/chromeos/login/login_display_host_impl.h"
12 #include "chrome/browser/chromeos/login/user_manager.h" 12 #include "chrome/browser/chromeos/login/user_manager.h"
13 #include "chrome/browser/chromeos/login/webui_login_view.h" 13 #include "chrome/browser/chromeos/login/webui_login_view.h"
14 #include "chrome/common/chrome_switches.h" 14 #include "chrome/common/chrome_switches.h"
15 #include "chromeos/chromeos_switches.h" 15 #include "chromeos/chromeos_switches.h"
16 #include "content/public/browser/notification_service.h" 16 #include "content/public/browser/notification_service.h"
17 #include "content/public/browser/web_contents.h" 17 #include "content/public/browser/web_contents.h"
18 #include "content/public/test/browser_test_utils.h" 18 #include "content/public/test/browser_test_utils.h"
19 #include "content/public/test/test_utils.h" 19 #include "content/public/test/test_utils.h"
20 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
21 21
22 namespace chromeos { 22 namespace chromeos {
23 23
24 LoginManagerTest::LoginManagerTest(bool should_launch_browser) 24 LoginManagerTestHelper::LoginManagerTestHelper(bool should_launch_browser)
25 : should_launch_browser_(should_launch_browser), 25 : should_launch_browser_(should_launch_browser),
26 web_contents_(NULL) { 26 web_contents_(NULL) {}
27 set_exit_when_last_browser_closes(false); 27
28 void LoginManagerTestHelper::SetUp() {
29 content::WindowedNotificationObserver(
30 chrome::NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE,
31 content::NotificationService::AllSources()).Wait();
32 InitializeWebContents();
28 } 33 }
29 34
30 void LoginManagerTest::CleanUpOnMainThread() { 35 void LoginManagerTestHelper::SetUpCommandLine(CommandLine* command_line) {
31 if (LoginDisplayHostImpl::default_host())
32 LoginDisplayHostImpl::default_host()->Finalize();
33 base::MessageLoop::current()->RunUntilIdle();
34 }
35
36 void LoginManagerTest::SetUpCommandLine(CommandLine* command_line) {
37 command_line->AppendSwitch(chromeos::switches::kLoginManager); 36 command_line->AppendSwitch(chromeos::switches::kLoginManager);
38 command_line->AppendSwitch(chromeos::switches::kForceLoginManagerInTests); 37 command_line->AppendSwitch(chromeos::switches::kForceLoginManagerInTests);
39 command_line->AppendSwitch(::switches::kMultiProfiles); 38 command_line->AppendSwitch(::switches::kMultiProfiles);
40 } 39 }
41 40
42 void LoginManagerTest::SetUpInProcessBrowserTestFixture() { 41 void LoginManagerTestHelper::SetUpLoginUtils() {
43 mock_login_utils_ = new testing::NiceMock<MockLoginUtils>(); 42 mock_login_utils_ = new testing::NiceMock<MockLoginUtils>();
44 mock_login_utils_->DelegateToFake(); 43 mock_login_utils_->DelegateToFake();
45 mock_login_utils_->GetFakeLoginUtils()->set_should_launch_browser( 44 mock_login_utils_->GetFakeLoginUtils()->set_should_launch_browser(
46 should_launch_browser_); 45 should_launch_browser_);
47 LoginUtils::Set(mock_login_utils_); 46 LoginUtils::Set(mock_login_utils_);
48 } 47 }
49 48
50 void LoginManagerTest::SetUpOnMainThread() { 49 void LoginManagerTestHelper::CleanUp() {
51 content::WindowedNotificationObserver( 50 if (LoginDisplayHostImpl::default_host())
52 chrome::NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE, 51 LoginDisplayHostImpl::default_host()->Finalize();
53 content::NotificationService::AllSources()).Wait(); 52 base::MessageLoop::current()->RunUntilIdle();
54 InitializeWebContents();
55 } 53 }
56 54
57 void LoginManagerTest::RegisterUser(const std::string& username) { 55 void LoginManagerTestHelper::RegisterUser(const std::string& username) {
58 ListPrefUpdate users_pref(g_browser_process->local_state(), "LoggedInUsers"); 56 ListPrefUpdate users_pref(g_browser_process->local_state(), "LoggedInUsers");
59 users_pref->AppendIfNotPresent(new base::StringValue(username)); 57 users_pref->AppendIfNotPresent(new base::StringValue(username));
60 } 58 }
61 59
62 void LoginManagerTest::SetExpectedCredentials(const std::string& username, 60 void LoginManagerTestHelper::SetExpectedCredentials(const std::string& username,
63 const std::string& password) { 61 const std::string& password) {
64 login_utils().GetFakeLoginUtils()->SetExpectedCredentials(username, password); 62 login_utils().GetFakeLoginUtils()->SetExpectedCredentials(username, password);
65 } 63 }
66 64
67 bool LoginManagerTest::TryToLogin(const std::string& username, 65 bool LoginManagerTestHelper::TryToLogIn(const std::string& username,
68 const std::string& password) { 66 const std::string& password) {
69 if (!AddUserTosession(username, password)) 67 if (!AddUserToSession(username, password))
70 return false; 68 return false;
71 if (const User* active_user = UserManager::Get()->GetActiveUser()) 69 if (const User* active_user = UserManager::Get()->GetActiveUser())
72 return active_user->email() == username; 70 return active_user->email() == username;
73 return false; 71 return false;
74 } 72 }
75 73
76 bool LoginManagerTest::AddUserTosession(const std::string& username, 74 bool LoginManagerTestHelper::AddUserToSession(const std::string& username,
77 const std::string& password) { 75 const std::string& password) {
78 ExistingUserController* controller = 76 ExistingUserController* controller =
79 ExistingUserController::current_controller(); 77 ExistingUserController::current_controller();
80 if (!controller) { 78 if (!controller) {
81 ADD_FAILURE(); 79 ADD_FAILURE();
82 return false; 80 return false;
83 } 81 }
84 controller->Login(UserContext(username, password, std::string())); 82 controller->Login(UserContext(username, password, std::string()));
85 content::WindowedNotificationObserver( 83 content::WindowedNotificationObserver(
86 chrome::NOTIFICATION_SESSION_STARTED, 84 chrome::NOTIFICATION_SESSION_STARTED,
87 content::NotificationService::AllSources()).Wait(); 85 content::NotificationService::AllSources()).Wait();
88 const UserList& logged_users = UserManager::Get()->GetLoggedInUsers(); 86 const UserList& logged_users = UserManager::Get()->GetLoggedInUsers();
89 for (UserList::const_iterator it = logged_users.begin(); 87 for (UserList::const_iterator it = logged_users.begin();
90 it != logged_users.end(); ++it) { 88 it != logged_users.end(); ++it) {
91 if ((*it)->email() == username) 89 if ((*it)->email() == username)
92 return true; 90 return true;
93 } 91 }
94 return false; 92 return false;
95 } 93 }
96 94
97 void LoginManagerTest::LoginUser(const std::string& username) { 95 void LoginManagerTestHelper::LogInUser(const std::string& username) {
98 SetExpectedCredentials(username, "password"); 96 SetExpectedCredentials(username, "password");
99 EXPECT_TRUE(TryToLogin(username, "password")); 97 EXPECT_TRUE(TryToLogIn(username, "password"));
100 } 98 }
101 99
102 void LoginManagerTest::AddUser(const std::string& username) { 100 void LoginManagerTestHelper::AddUser(const std::string& username) {
103 SetExpectedCredentials(username, "password"); 101 SetExpectedCredentials(username, "password");
104 EXPECT_TRUE(AddUserTosession(username, "password")); 102 EXPECT_TRUE(AddUserToSession(username, "password"));
105 } 103 }
106 104
107 void LoginManagerTest::JSExpect(const std::string& expression) { 105 void LoginManagerTestHelper::JSExpect(const std::string& expression) {
108 js_checker_.ExpectTrue(expression); 106 js_checker_.ExpectTrue(expression);
109 } 107 }
110 108
111 void LoginManagerTest::InitializeWebContents() { 109 void LoginManagerTestHelper::InitializeWebContents() {
112 LoginDisplayHost* host = LoginDisplayHostImpl::default_host(); 110 LoginDisplayHost* host = LoginDisplayHostImpl::default_host();
113 EXPECT_TRUE(host != NULL); 111 EXPECT_TRUE(host != NULL);
114 112
115 content::WebContents* web_contents = 113 content::WebContents* web_contents =
116 host->GetWebUILoginView()->GetWebContents(); 114 host->GetWebUILoginView()->GetWebContents();
117 EXPECT_TRUE(web_contents != NULL); 115 EXPECT_TRUE(web_contents != NULL);
118 set_web_contents(web_contents); 116 set_web_contents(web_contents);
119 js_checker_.set_web_contents(web_contents); 117 js_checker_.set_web_contents(web_contents);
120 } 118 }
121 119
122 } // namespace chromeos 120 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698