Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: runtime/lib/compact_hash.dart

Issue 2705593002: Fix various nits in VM patch files. (Closed)
Patch Set: Address comments and issues found during testing. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/bigint.dart ('k') | runtime/lib/developer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:typed_data' show Uint32List;
6
5 // Hash table with open addressing that separates the index from keys/values. 7 // Hash table with open addressing that separates the index from keys/values.
6 8
7 abstract class _HashFieldBase { 9 abstract class _HashFieldBase {
8 // Each occupied entry in _index is a fixed-size integer that encodes a pair: 10 // Each occupied entry in _index is a fixed-size integer that encodes a pair:
9 // [ hash pattern for key | index of entry in _data ] 11 // [ hash pattern for key | index of entry in _data ]
10 // The hash pattern is based on hashCode, but is guaranteed to be non-zero. 12 // The hash pattern is based on hashCode, but is guaranteed to be non-zero.
11 // The length of _index is always a power of two, and there is always at 13 // The length of _index is always a power of two, and there is always at
12 // least one unoccupied entry. 14 // least one unoccupied entry.
13 // NOTE: When maps are deserialized, their _index and _hashMask is regenerated 15 // NOTE: When maps are deserialized, their _index and _hashMask is regenerated
14 // lazily by _regenerateIndex. 16 // lazily by _regenerateIndex.
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 E lookup(Object o) => _validKey(o) ? super.lookup(o) : null; 591 E lookup(Object o) => _validKey(o) ? super.lookup(o) : null;
590 bool remove(Object o) => _validKey(o) ? super.remove(o) : false; 592 bool remove(Object o) => _validKey(o) ? super.remove(o) : false;
591 593
592 _CompactLinkedCustomHashSet(this._equality, this._hasher, validKey) 594 _CompactLinkedCustomHashSet(this._equality, this._hasher, validKey)
593 : _validKey = (validKey != null) ? validKey : new _TypeTest<E>().test; 595 : _validKey = (validKey != null) ? validKey : new _TypeTest<E>().test;
594 596
595 Set<E> toSet() => 597 Set<E> toSet() =>
596 new _CompactLinkedCustomHashSet<E>(_equality, _hasher, _validKey) 598 new _CompactLinkedCustomHashSet<E>(_equality, _hasher, _validKey)
597 ..addAll(this); 599 ..addAll(this);
598 } 600 }
OLDNEW
« no previous file with comments | « runtime/lib/bigint.dart ('k') | runtime/lib/developer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698