[inspector] remove iterators and for...of loops from injected-script-source

test/inspector/inspector-test.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(_WIN32) && !defined(_WIN64)
 #include <unistd.h>  // NOLINT
 #endif               // !defined(_WIN32) && !defined(_WIN64)
 
 #include <locale.h>
 
@@ skipping 364 matching lines @@
 
 class InspectorExtension : public v8::Extension {
  public:
   InspectorExtension()
       : v8::Extension("v8_inspector/inspector",
                       "native function attachInspector();"
                       "native function detachInspector();"
                       "native function setMaxAsyncTaskStacks();"
                       "native function breakProgram();"
                       "native function createObjectWithStrictCheck();"
-                      "native function callWithScheduledBreak();") {}
+                      "native function callWithScheduledBreak();"
+                      "native function allowAccessorFormatting();") {}
 
   virtual v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
       v8::Isolate* isolate, v8::Local<v8::String> name) {
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
     if (name->Equals(context,
                      v8::String::NewFromUtf8(isolate, "attachInspector",
                                              v8::NewStringType::kNormal)
                          .ToLocalChecked())
             .FromJust()) {
       return v8::FunctionTemplate::New(isolate, InspectorExtension::Attach);
@@ skipping 24 matching lines @@
                    .FromJust()) {
       return v8::FunctionTemplate::New(
           isolate, InspectorExtension::CreateObjectWithStrictCheck);
     } else if (name->Equals(context, v8::String::NewFromUtf8(
                                          isolate, "callWithScheduledBreak",
                                          v8::NewStringType::kNormal)
                                          .ToLocalChecked())
                    .FromJust()) {
       return v8::FunctionTemplate::New(
           isolate, InspectorExtension::CallWithScheduledBreak);
+    } else if (name->Equals(context, v8::String::NewFromUtf8(
+                                         isolate, "allowAccessorFormatting",
+                                         v8::NewStringType::kNormal)
+                                         .ToLocalChecked())
+                   .FromJust()) {
+      return v8::FunctionTemplate::New(
+          isolate, InspectorExtension::AllowAccessorFormatting);
     }
     return v8::Local<v8::FunctionTemplate>();
   }
 
  private:
   static void Attach(const v8::FunctionCallbackInfo<v8::Value>& args) {
     v8::Isolate* isolate = args.GetIsolate();
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
     v8_inspector::V8Inspector* inspector =
         InspectorClientImpl::InspectorFromContext(context);
@@ skipping 78 matching lines @@
     v8_inspector::StringView reason_view(reason.start(), reason.length());
     v8::internal::Vector<uint16_t> details = ToVector(args[2].As<v8::String>());
     v8_inspector::StringView details_view(details.start(), details.length());
     session->schedulePauseOnNextStatement(reason_view, details_view);
     v8::Local<v8::Context> context = args.GetIsolate()->GetCurrentContext();
     v8::MaybeLocal<v8::Value> result;
     result = args[0].As<v8::Function>()->Call(context, context->Global(), 0,
                                               nullptr);
     session->cancelPauseOnNextStatement();
   }
+
+  static void AllowAccessorFormatting(
+      const v8::FunctionCallbackInfo<v8::Value>& args) {
+    if (args.Length() != 1) {

[kozy, 2017/03/03 18:20:35]

&& args[0]->IsObject()

[luoe, 2017/03/03 18:56:21]

Replaced the CHECK on L544 with a condition as you suggested.

+      fprintf(stderr, "Internal error: allowAccessorFormatting('object').");
+      Exit();
+    }
+    v8::Local<v8::Object> object = args[0].As<v8::Object>();
+    CHECK(object->IsObject());
+    v8::Isolate* isolate = args.GetIsolate();
+    v8::Local<v8::Private> shouldFormatAccessorsPrivate = v8::Private::ForApi(
+        isolate, v8::String::NewFromUtf8(isolate, "allowAccessorFormatting",
+                                         v8::NewStringType::kNormal)
+                     .ToLocalChecked());
+    object
+        ->SetPrivate(isolate->GetCurrentContext(), shouldFormatAccessorsPrivate,
+                     v8::Null(isolate))
+        .ToChecked();
+  }
 };
 
 v8::Local<v8::String> ToString(v8::Isolate* isolate,
                                const v8_inspector::StringView& string) {
   if (string.is8Bit())
     return v8::String::NewFromOneByte(isolate, string.characters8(),
                                       v8::NewStringType::kNormal,
                                       static_cast<int>(string.length()))
         .ToLocalChecked();
   else
@@ skipping 92 matching lines @@
               argv[i]);
       Exit();
     }
     frontend_runner.Append(new ExecuteStringTask(chars));
   }
 
   frontend_runner.Join();
   backend_runner.Join();
   return 0;
 }