Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 270553005: Support warning decorations in Timeline flame chart based on trace events (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index 6c70e09493503d41c00d374367afdaeaa6ba1683..b1473b672142285c1895decf2779c31df4c6848e 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -633,7 +633,42 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
*/
decorateEntry: function(entryIndex, context, text, barX, barY, barWidth, barHeight, offsetToPosition)
{
- return false;
+ if (barWidth < 5)
+ return false;
+
+ var record = this._records[entryIndex];
+ var timelineData = this._timelineData;
+
+ var category = WebInspector.TimelineUIUtils.styleForTimelineEvent(record.name).category;
+ // Paint text using white color on dark background.
+ if (text) {
+ context.save();
+ context.fillStyle = "white";
+ context.shadowColor = "rgba(0, 0, 0, 0.1)";
+ context.shadowOffsetX = 1;
+ context.shadowOffsetY = 1;
+ context.font = this._font;
+ context.fillText(text, barX + this.textPadding(), barY + barHeight - this.textBaseline());
+ context.restore();
+ }
+
+ if (this._model.bindings().eventWarning(record)) {
+ context.save();
+
+ context.rect(barX, barY, barWidth, this.barHeight());
+ context.clip();
+
+ context.beginPath();
+ context.fillStyle = "red";
+ context.moveTo(barX + barWidth - 15, barY + 1);
+ context.lineTo(barX + barWidth - 1, barY + 1);
+ context.lineTo(barX + barWidth - 1, barY + 15);
+ context.fill();
+
+ context.restore();
+ }
+
+ return true;
},
/**
@@ -642,10 +677,11 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
*/
forceDecoration: function(entryIndex)
{
- return false;
+ var record = this._records[entryIndex];
+ return !!this._model.bindings().eventWarning(record);
},
- /**
+ /**
* @param {number} entryIndex
* @return {?{startTimeOffset: number, endTimeOffset: number}}
*/

Powered by Google App Engine
This is Rietveld 408576698