Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 270553003: Linux: Remove gcrypt initialization workaround. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Linux: Remove gcrypt initialization workaround. BUG=369973 TEST=ctrl + p does not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271563

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -83 lines) Patch
M chrome/installer/linux/debian/expected_deps View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/print_backend_cups.cc View 1 3 chunks +0 lines, -79 lines 0 comments Download
M printing/printing.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Lei Zhang
I think all supported Linux distros have a new-enough libgnutls?
6 years, 7 months ago (2014-05-07 02:35:25 UTC) #1
Lei Zhang
Pawel, do you want to review this?
6 years, 7 months ago (2014-05-08 20:34:39 UTC) #2
Lei Zhang
ping?
6 years, 7 months ago (2014-05-12 23:36:59 UTC) #3
Lei Zhang
+vitaly
6 years, 7 months ago (2014-05-15 07:02:06 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 7 months ago (2014-05-15 16:22:50 UTC) #5
Paweł Hajdan Jr.
LGTM
6 years, 7 months ago (2014-05-16 12:53:33 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-19 20:59:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/270553003/20001
6 years, 7 months ago (2014-05-19 21:01:05 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 01:35:36 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 02:28:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155241)
6 years, 7 months ago (2014-05-20 02:28:10 UTC) #11
Lei Zhang (Do not use)
The CQ bit was checked by thestig@google.com
6 years, 7 months ago (2014-05-20 02:29:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/270553003/20001
6 years, 7 months ago (2014-05-20 02:30:36 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 04:13:51 UTC) #14
Message was sent while issue was closed.
Change committed as 271563

Powered by Google App Engine
This is Rietveld 408576698