Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 27055003: Remove a bunch of unused webkitpy code from tool/, common/checkout/ and common/config/ (Closed)

Created:
7 years, 2 months ago by Dirk Pranke
Modified:
7 years, 2 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Remove a bunch of unused webkitpy code. This patch removes a bunch of webkit-patch steps and related code that was primarily concerned w/ interacting w/ Bugzilla and/or other WebKit-based ports. Among the things/files removed: the Checkout module, the DeprecatedPort module, and a bunch of steps. This patch also promotes all the remaining webkit-patch commands that are meant to be run by the user to the main 'webkit patch help' list. Now 'help --all-commands' lists the main commands plus the internal commands like rebaseline-test-internal. In theory, no one was using any of this stuff so it should be safe to remove. I guess we'll see :). BUG= R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2801 lines) Patch
M Tools/Scripts/webkitpy/common/checkout/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
D Tools/Scripts/webkitpy/common/checkout/checkout.py View 1 chunk +0 lines, -78 lines 0 comments Download
D Tools/Scripts/webkitpy/common/checkout/checkout_mock.py View 1 chunk +0 lines, -61 lines 0 comments Download
D Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py View 1 chunk +0 lines, -59 lines 0 comments Download
D Tools/Scripts/webkitpy/common/config/ports.py View 1 chunk +0 lines, -118 lines 0 comments Download
D Tools/Scripts/webkitpy/common/config/ports_unittest.py View 1 chunk +0 lines, -40 lines 0 comments Download
M Tools/Scripts/webkitpy/common/host.py View 3 chunks +0 lines, -7 lines 0 comments Download
M Tools/Scripts/webkitpy/common/host_mock.py View 2 chunks +0 lines, -2 lines 0 comments Download
D Tools/Scripts/webkitpy/common/net/credentials.py View 1 chunk +0 lines, -163 lines 0 comments Download
D Tools/Scripts/webkitpy/common/net/credentials_unittest.py View 1 chunk +0 lines, -208 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/commitannouncer.py View 1 chunk +1 line, -0 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/commands/download.py View 1 chunk +0 lines, -61 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/commands/download_unittest.py View 1 chunk +0 lines, -56 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/flakytests.py View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/gardenomatic.py View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/queries.py View 3 chunks +3 lines, -0 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/commands/queuestest.py View 1 chunk +0 lines, -107 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 5 chunks +5 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/stepsequence.py View 2 chunks +0 lines, -7 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/comments.py View 1 chunk +0 lines, -42 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/main.py View 4 chunks +0 lines, -9 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/__init__.py View 1 chunk +0 lines, -14 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/abstractstep.py View 1 chunk +0 lines, -27 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py View 1 chunk +0 lines, -80 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py View 1 chunk +0 lines, -58 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/applypatch.py View 1 chunk +0 lines, -46 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/checkstyle.py View 1 chunk +0 lines, -67 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py View 1 chunk +0 lines, -50 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py View 1 chunk +0 lines, -68 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/commit.py View 1 chunk +0 lines, -108 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/commit_unittest.py View 1 chunk +0 lines, -68 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/discardlocalchanges.py View 1 chunk +0 lines, -52 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py View 1 chunk +0 lines, -97 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py View 1 chunk +0 lines, -41 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py View 1 chunk +0 lines, -48 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/haslanded.py View 1 chunk +0 lines, -120 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/haslanded_unittest.py View 1 chunk +0 lines, -299 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/metastep.py View 1 chunk +0 lines, -54 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/obsoletepatches.py View 1 chunk +0 lines, -54 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/postdiff.py View 1 chunk +0 lines, -52 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py View 1 chunk +0 lines, -45 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py View 1 chunk +0 lines, -47 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/revertrevision.py View 1 chunk +0 lines, -35 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/runtests.py View 1 chunk +0 lines, -108 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py View 1 chunk +0 lines, -61 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/steps/steps_unittest.py View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ojan
lgtm rs=me
7 years, 2 months ago (2013-10-12 00:22:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/27055003/1
7 years, 2 months ago (2013-10-12 00:30:33 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=10703
7 years, 2 months ago (2013-10-12 08:49:25 UTC) #3
Dirk Pranke
7 years, 2 months ago (2013-10-14 18:37:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r159595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698