Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/resources/audit.js

Issue 2705483002: Print out label and description on task entry in Audit task runner (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/resources/audit.js
diff --git a/third_party/WebKit/LayoutTests/webaudio/resources/audit.js b/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
index 7e732952a3968ed6ea2c9586d92c71a9b353ce83..cf1cfb7f1c51f8bb53796bc8bbbb727b4c06470d 100644
--- a/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
+++ b/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
@@ -934,11 +934,10 @@ window.Audit = (function () {
}
// Set the description of this task. This is printed out in the test
- // result.
+ // result right after the task starts.
describe (message) {
this._description = message;
- _logPassed('> [' + this._label + '] '
- + this._description);
+ _logPassed(' : ' + this._description);
}
get state () {
@@ -962,6 +961,7 @@ window.Audit = (function () {
// task function.
run () {
this._state = TaskState.STARTED;
+ _logPassed('> [' + this._label + '] task started.');
Raymond Toy 2017/02/16 21:50:40 I think I'd prefer nothing be printed. Because wh
hongchan 2017/02/16 23:54:49 If your description is undefined or null, you'll g
this._taskFunction(
this,
this.should.bind(this));

Powered by Google App Engine
This is Rietveld 408576698