Last_n: disable on Svelte devices.

chrome/browser/android/offline_pages/recent_tab_helper.h

Index: chrome/browser/android/offline_pages/recent_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.h b/chrome/browser/android/offline_pages/recent_tab_helper.h
index b5f095f846243f537d86c6dca0ce979844915603..3e40c1ea8fbc70b3ecff5d803ccade672b16e316 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.h
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.h
@@ -87,6 +87,7 @@ class RecentTabHelper
 
   explicit RecentTabHelper(content::WebContents* web_contents);
   friend class content::WebContentsUserData<RecentTabHelper>;
+  FRIEND_TEST_ALL_PREFIXES(RecentTabHelperTest, LastNDisabledOnSvelte);

[Dmitry Titov, 2017/02/16 20:58:41]

Could we add a getter on Delegate to return whether it's a low end device? We
already use Delegate here for dependency injection during testing, so would be
nice to only have one method.

[carlosk, 2017/02/16 21:48:16]

Done. I also added a getter for the initial test delegate created by
RecentTabHelperTest::SetUp as it was unnecessary to create a new one in 3 test
cases (including this new one).

 
   bool EnsureInitialized();
   void ContinueSnapshotWithIdsToPurge(SnapshotProgressInfo* snapshot_info,
@@ -152,6 +153,9 @@ class RecentTabHelper
   SnapshotController::PageQuality last_n_latest_saved_quality_ =
       SnapshotController::PageQuality::POOR;
 
+  // Cached value of whether low end device. Overwritable for testing.
+  bool is_low_end_device_;
+
   base::WeakPtrFactory<RecentTabHelper> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RecentTabHelper);