Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: trunk/src/sync/syncable/directory_backing_store.cc

Issue 270543005: Revert 270308 "sync: Improve handling of bad UniquePositions" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/sync/sync_tests.gypi ('k') | trunk/src/sync/syncable/directory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/sync/syncable/directory_backing_store.cc
===================================================================
--- trunk/src/sync/syncable/directory_backing_store.cc (revision 270322)
+++ trunk/src/sync/syncable/directory_backing_store.cc (working copy)
@@ -123,16 +123,6 @@
kernel->mutable_ref(static_cast<AttachmentMetadataField>(i)).ParseFromArray(
statement->ColumnBlob(i), statement->ColumnByteLength(i));
}
-
- // Sanity check on positions. We risk strange and rare crashes if our
- // assumptions about unique position values are broken.
- if (kernel->ShouldMaintainPosition() &&
- !kernel->ref(UNIQUE_POSITION).IsValid()) {
- DVLOG(1) << "Unpacked invalid position on an entity that should have a "
- << "valid position. Assuming the DB is corrupt.";
- return scoped_ptr<EntryKernel>();
- }
-
return kernel.Pass();
}
« no previous file with comments | « trunk/src/sync/sync_tests.gypi ('k') | trunk/src/sync/syncable/directory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698