Issue 270543005: Revert 270308 "sync: Improve handling of bad UniquePositions"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270543005: Revert 270308 "sync: Improve handling of bad UniquePositions" (Closed)

Created:
6 years, 7 months ago by raymes

Modified:
6 years, 7 months ago

Reviewers:
rlarocque

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 270308 "sync: Improve handling of bad UniquePositions" Reverting due to possible build breakage: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%20LSan%20Tests%20%282%29&number=2633 > sync: Improve handling of bad UniquePositions > > Makes the client assign a valid position to incoming bookmarks if the > server has not populated the required fields. This code should never be > triggered unless there is a bug in the server. This risks reordering > users' bookmarks, but that's probably preferable to a crash. > > Detects bookmarks that do not have valid position information during > database load. If these corrupted bookmarks are detected, the entire > database is declared to be corrupt. Sync will then re-download > all of the user's data, which should fix the problem. > > BUG=367247 > > Review URL: https://codereview.chromium.org/278153002 TBR=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270324

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -204 lines)			Patch
M	trunk/src/sync/engine/syncer_util.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	trunk/src/sync/engine/syncer_util.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
D	trunk/src/sync/engine/syncer_util_unittest.cc	View	1 chunk	+0 lines, -127 lines	0 comments	Download
M	trunk/src/sync/internal_api/public/base/unique_position.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/sync/internal_api/public/base/unique_position.cc	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	trunk/src/sync/sync_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/sync/syncable/directory_backing_store.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/src/sync/syncable/directory_unittest.cc	View	2 chunks	+0 lines, -37 lines	0 comments	Download
M	trunk/src/sync/syncable/syncable_unittest.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

raymes

6 years, 7 months ago (2014-05-14 03:44:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r270324 (tree was closed).

Expand Messages | Collapse Messages