Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: dm/DMUtil.h

Issue 270543004: DM: Add --skps. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix and verbatim Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dm/DMSKPTask.h ('K') | « dm/DMSKPTask.cpp ('k') | dm/DMUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMUtil.h
diff --git a/dm/DMUtil.h b/dm/DMUtil.h
index 1145f28221014b5f8a1b7e25c451750086b0bcea..46a96aa248c0b508265e0c56aa4f3bd727bb2609 100644
--- a/dm/DMUtil.h
+++ b/dm/DMUtil.h
@@ -24,6 +24,7 @@ SkPicture* RecordPicture(skiagm::GM* gm,
// TODO(mtklein): make SkBenchmark::getSize()/GM::getISize() const.
void SetupBitmap(const SkColorType, skiagm::GM* gm, SkBitmap* bitmap);
void SetupBitmap(const SkColorType, SkBenchmark* bench, SkBitmap* bitmap);
reed1 2014/05/14 12:40:11 nit: using 'const' on POD parameters seems funny,
mtklein 2014/05/14 17:47:18 Yeah, don't know how that got there in the first p
+void SetupBitmap(const SkColorType, const SkPicture& picture, SkBitmap* bitmap);
// Draw picture to bitmap.
void DrawPicture(SkPicture* picture, SkBitmap* bitmap);
« dm/DMSKPTask.h ('K') | « dm/DMSKPTask.cpp ('k') | dm/DMUtil.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698