Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2705403003: Convert FrameView timer to UnspecedTimer frame-specific timer. (Closed)

Created:
3 years, 10 months ago by joelhockey
Modified:
3 years, 10 months ago
Reviewers:
slangley, haraken, dcheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert FrameView timer to UnspecedTimer frame-specific timer. Convert FrameView timer to UnspecedTimer frame-specific timer. BUG=624694 Review-Url: https://codereview.chromium.org/2705403003 Cr-Commit-Position: refs/heads/master@{#452310} Committed: https://chromium.googlesource.com/chromium/src/+/99fc4ddff50e25a6c65b2ab95a3d6d2cbe1c226f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
joelhockey
Other 2 timers were changed by dcheng in https://codereview.chromium.org/2556993005. Daniel, was there a reason you ...
3 years, 10 months ago (2017-02-22 07:03:46 UTC) #3
haraken
LGTM but add more explanation to the CL description (why is it a unspeced timer?).
3 years, 10 months ago (2017-02-22 07:04:42 UTC) #4
dcheng
On 2017/02/22 07:03:46, joelhockey wrote: > Other 2 timers were changed by dcheng in > ...
3 years, 10 months ago (2017-02-22 07:16:21 UTC) #5
joelhockey
On 2017/02/22 at 07:04:42, haraken wrote: > LGTM but add more explanation to the CL ...
3 years, 10 months ago (2017-02-22 07:30:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705403003/1
3 years, 10 months ago (2017-02-22 07:31:39 UTC) #8
dcheng
FWIW, for UnspeccedTimer, I usually say something like: This timer controls <internal feature X>, which ...
3 years, 10 months ago (2017-02-22 07:35:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/387233)
3 years, 10 months ago (2017-02-22 11:02:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705403003/1
3 years, 10 months ago (2017-02-22 22:55:35 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:38:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99fc4ddff50e25a6c65b2ab95a3d...

Powered by Google App Engine
This is Rietveld 408576698