media/formats/mpeg/mpeg1_audio_stream_parser.cc - Issue 2705353002: Fix mpeg-1 layer2 parsing typo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/mpeg1_audio_stream_parser.cc

Issue 2705353002: Fix mpeg-1 layer2 parsing typo. (Closed)

Patch Set: Nuke comment. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mpeg/mpeg1_audio_stream_parser.cc

diff --git a/media/formats/mpeg/mpeg1_audio_stream_parser.cc b/media/formats/mpeg/mpeg1_audio_stream_parser.cc

index bf5d1cbdef45f74bece282c9ba425f3cf21a529b..a86c1e1b1ae07cb008d239074bede92cdcb4faef 100644

--- a/media/formats/mpeg/mpeg1_audio_stream_parser.cc

+++ b/media/formats/mpeg/mpeg1_audio_stream_parser.cc

@@ -138,7 +138,7 @@ bool MPEG1AudioStreamParser::ParseHeader(

return false;

}

- if (layer == kLayer2 && kIsAllowed[bitrate_index][channel_mode]) {

+ if (layer == kLayer2 && !kIsAllowed[bitrate_index][channel_mode]) {

MEDIA_LOG(ERROR, media_log) << "Invalid (bitrate_index, channel_mode)"

<< " combination :" << std::hex

<< " bitrate_index " << bitrate_index

« no previous file with comments | « no previous file | media/formats/mpeg/mpeg1_audio_stream_parser_unittest.cc » ('j') | no next file with comments »