Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

ui/ozone/BUILD.gn

Index: ui/ozone/BUILD.gn
diff --git a/ui/ozone/BUILD.gn b/ui/ozone/BUILD.gn
index 7d0570bd04b9158073cb80cea0f733678d3de3d7..33c63165ab96567b870aaa815475f43483b2eca4 100644
--- a/ui/ozone/BUILD.gn
+++ b/ui/ozone/BUILD.gn
@@ -122,7 +122,6 @@ source_set("platform") {
   ]
 
   public = [
-    "public/client_native_pixmap_factory.h",
     "public/ozone_gpu_test_helper.h",
     "public/ozone_platform.h",
   ]
@@ -154,7 +153,13 @@ source_set("platform") {
   allow_circular_includes_from = ozone_platform_deps
 
   # This is used for platform tests.
-  visibility += [ "//ui/ozone/platform/*" ]
+  visibility += [

[spang, 2017/02/27 18:49:05]

This is definitely not OK.

:platform is for platform tests only as it exposes a non-componentized version
of ozone. Depending on this directly from the listed components will cause ODR
violations.

[Julien Isorce, 2017/03/10 16:55:50]

Done.

+    "//content/renderer:renderer",
+    "//gpu/ipc/common:ipc_common_sources",
+    "//services/ui:lib",
+    "//ui/ozone/gl:ozone_gl_unittests",
+    "//ui/ozone/platform/*",
+  ]
 }
 
 component("ozone") {
@@ -200,8 +205,8 @@ action("generate_constructor_list") {
     "--namespace=ui",
     "--typename=OzonePlatform",
     "--typename=ClientNativePixmapFactory",
+    "--include=\"ui/gfx/client_native_pixmap_factory.h\"",
     "--include=\"ui/ozone/public/ozone_platform.h\"",
-    "--include=\"ui/ozone/public/client_native_pixmap_factory.h\"",
   ]
 
   deps = [