Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: tools/presubmit.py

Issue 2705333005: Add checkdeps to tools/presubmit.py. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index e8ab51147991a7149c0e1845e2709446daf75602..98574970c265173c2b3a059fe31c389350d4ae18 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -516,6 +516,11 @@ class StatusFilesProcessor(SourceFileProcessor):
return success
+def CheckDeps(workspace):
+ checkdeps_py = join(workspace, 'buildtools', 'checkdeps', 'checkdeps.py')
+ return subprocess.call([sys.executable, checkdeps_py, workspace]) == 0
+
+
def GetOptions():
result = optparse.OptionParser()
result.add_option('--no-lint', help="Do not run cpplint", default=False,
@@ -528,6 +533,8 @@ def Main():
parser = GetOptions()
(options, args) = parser.parse_args()
success = True
+ print "Running checkdeps..."
+ success &= CheckDeps(workspace)
print "Running C++ lint check..."
if not options.no_lint:
success &= CppLintProcessor().RunOnPath(workspace)
« no previous file with comments | « src/inspector/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698