Make src/task/strong tests into classes and asynchronous.

Make src/task/strong tests into classes and asynchronous.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/7a321225f0607563dc915fb3db6056107bc33929

[Brian Wilkerson, 2017-02-23 20:45:33]

lgtm

mostly just questions to aid my understanding

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_ast_test.dart (right):

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_ast_test.dart:192:
checkFileElement(r'''
Not sure why we don't need to return the value here in order to keep the test
from completing before checkFileElement has had a chance to run. Seems like we
could loose failures.

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:21: await checkFile('''
Could we just return here rather than await? Is there a preference for using one
over the other? (It seems inconsistent with the previous file).

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:18: //import
'strong_test_helper.dart' as helper;
Remove?

[scheglov, 2017-02-23 20:54:02]

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_ast_test.dart (right):

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_ast_test.dart:192:
checkFileElement(r'''
On 2017/02/23 20:45:33, Brian Wilkerson wrote:
> Not sure why we don't need to return the value here in order to keep the test
> from completing before checkFileElement has had a chance to run. Seems like we
> could loose failures.

Thank you for catching this.
Fixed.

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:21: await checkFile('''
On 2017/02/23 20:45:33, Brian Wilkerson wrote:
> Could we just return here rather than await? Is there a preference for using
one
> over the other? (It seems inconsistent with the previous file).

We could, and we also could remove the "async" modifier.
I prefer writing in procedural style though.
There is some overhead, but probably does not matter for these tests.

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/2705323005/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:18: //import
'strong_test_helper.dart' as helper;
On 2017/02/23 20:45:33, Brian Wilkerson wrote:
> Remove?

Done.

[scheglov, 2017-02-23 20:54:17]

Description was changed from

==========
Make src/task/strong tests into classes and asynchronous.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Make src/task/strong tests into classes and asynchronous.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/7a321225f0607563dc915fb3db6056107bc33929
==========

[scheglov, 2017-02-23 20:54:18]

Committed patchset #1 (id:1) manually as
7a321225f0607563dc915fb3db6056107bc33929 (presubmit successful).