Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3748)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 2705323004: Anchor the first run bubble off the location bar icon's ImageView. (Closed)
Patch Set: GetSecurityBubbleAnchorView Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index a2cbbbe733709e5a2f77e9139b2991e360eebf81..5e588a8186f4fa94e36b350c88698c78198f9583 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -853,7 +853,7 @@ void LocationBarView::ShowFirstRunBubbleInternal() {
return;
Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
if (browser)
- FirstRunBubble::ShowBubble(browser, location_icon_view_);
+ FirstRunBubble::ShowBubble(browser, GetSecurityBubbleAnchorView());
Peter Kasting 2017/02/24 01:55:54 (Still wondering if maybe this should be renamed t
tapted 2017/02/24 02:01:24 If it's OK, I might defer the rename.. Someone mig
Peter Kasting 2017/02/24 02:05:16 Ha! I'm pretty sure THIS one, at least, I know ho
#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698