Anchor the first run bubble off the location bar icon's ImageView.

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/i18n/rtl.h"
@@ skipping 835 matching lines @@
 }
 
 void LocationBarView::ShowFirstRunBubbleInternal() {
   // First run bubble doesn't make sense for Chrome OS.
 #if !defined(OS_CHROMEOS)
   WebContents* web_contents = delegate_->GetWebContents();
   if (!web_contents)
     return;
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
   if (browser)
-    FirstRunBubble::ShowBubble(browser, location_icon_view_);
+    FirstRunBubble::ShowBubble(browser, location_icon_view_->GetImageView());

[Peter Kasting, 2017/02/23 22:06:03]

It seems like this should just call GetSecurityBubbleAnchorView().  (If the name
is now too specific, we could rename this, although I don't have any great name
suggestions.)

Otherwise it seems like we will need to fix this again for Harmony, to just
duplicate that code.

[tapted, 2017/02/23 23:19:48]

Done.

I had debated this and couldn't decide :). We don't have mocks for the first run
bubble. The bubble says "you can search from here with Google" and points to a
magnifying glass. Seems weird to have a bubble that says "look here" and doesn't
have an arrow on it, but the way BubbleFrameView is set up under harmony, the
arrow is removed regardless of where we anchor it (and I guess it doesn't look
too bad).

 #endif
 }
 
 base::string16 LocationBarView::GetLocationIconText() const {
   if (GetToolbarModel()->GetURL().SchemeIs(content::kChromeUIScheme))
     return l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME);
 
   const base::string16 extension_name = GetExtensionName(
       GetToolbarModel()->GetURL(), delegate_->GetWebContents());
   if (!extension_name.empty())
@@ skipping 340 matching lines @@
 // LocationBarView, private TemplateURLServiceObserver implementation:
 
 void LocationBarView::OnTemplateURLServiceChanged() {
   template_url_service_->RemoveObserver(this);
   template_url_service_ = nullptr;
   // If the browser is no longer active, let's not show the info bubble, as this
   // would make the browser the active window again.
   if (omnibox_view_ && omnibox_view_->GetWidget()->IsActive())
     ShowFirstRunBubble();
 }