ios/web/navigation/navigation_manager_impl_unittest.mm - Issue 2705293014: Created web::UserAgentType.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/navigation/navigation_manager_impl_unittest.mm

Issue 2705293014: Created web::UserAgentType. (Closed)

Patch Set: fix GetLastCommittedWebItem Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/web/navigation/navigation_manager_impl.mm ('K') | « ios/web/navigation/navigation_manager_impl.mm ('k') | ios/web/public/crw_navigation_item_storage.h » ('j') | ios/web/public/crw_navigation_item_storage.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "ios/web/navigation/navigation_manager_impl.h"	5 #import "ios/web/navigation/navigation_manager_impl.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #import "base/mac/scoped_nsobject.h"	8 #import "base/mac/scoped_nsobject.h"

9 #import "ios/web/navigation/crw_session_controller+private_constructors.h"	9 #import "ios/web/navigation/crw_session_controller+private_constructors.h"

10 #import "ios/web/navigation/navigation_manager_delegate.h"	10 #import "ios/web/navigation/navigation_manager_delegate.h"

(...skipping 497 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
508 }	508 }

509	509

510 // Tests that desktop user agent can be enforced to use for next pending item.	510 // Tests that desktop user agent can be enforced to use for next pending item.

511 TEST_F(NavigationManagerTest, OverrideDesktopUserAgent) {	511 TEST_F(NavigationManagerTest, OverrideDesktopUserAgent) {

512 navigation_manager()->OverrideDesktopUserAgentForNextPendingItem();	512 navigation_manager()->OverrideDesktopUserAgentForNextPendingItem();

513 navigation_manager()->AddPendingItem(	513 navigation_manager()->AddPendingItem(

514 GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,	514 GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,

515 web::NavigationInitiationType::USER_INITIATED);	515 web::NavigationInitiationType::USER_INITIATED);

516 [session_controller() commitPendingItem];	516 [session_controller() commitPendingItem];

517 NavigationItem* visible_item = navigation_manager()->GetVisibleItem();	517 NavigationItem* visible_item = navigation_manager()->GetVisibleItem();

518 EXPECT_TRUE(visible_item->IsOverridingUserAgent());	518 EXPECT_EQ(visible_item->GetUserAgentType(), UserAgentType::DESKTOP);

519 }	519 }

520	520
	Eugene But (OOO till 7-30) 2017/02/25 01:51:52 There was quite a few logic changes in the code. C There was quite a few logic changes in the code. Could you please write tests to cover those and a new method. kkhorimoto 2017/02/27 23:29:04 Done. Show quoted text On 2017/02/25 01:51:52, Eugene But wrote: > There was quite a few logic changes in the code. Could you please write tests to > cover those and a new method. Done.
521 } // namespace web	521 } // namespace web

OLD	NEW