Created web::UserAgentType.

ios/chrome/browser/web/chrome_web_client.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/web/chrome_web_client.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/ios/ios_util.h"
 #include "base/mac/bundle_locations.h"
@@ skipping 90 matching lines @@
 base::string16 ChromeWebClient::GetPluginNotSupportedText() const {
   return l10n_util::GetStringUTF16(IDS_PLUGIN_NOT_SUPPORTED);
 }
 
 std::string ChromeWebClient::GetProduct() const {
   std::string product("CriOS/");
   product += version_info::GetVersionNumber();
   return product;
 }
 
-std::string ChromeWebClient::GetUserAgent(bool desktop_user_agent) const {
+std::string ChromeWebClient::GetUserAgent(web::UserAgentType type) const {
+  // The user agent should not be requested for app-specific URLs.
+  if (type == web::UserAgentType::NONE) {
+    NOTREACHED();
+    return std::string();

[liaoyuke, 2017/02/25 01:28:19]

Do we really need this return statement?

[kkhorimoto, 2017/02/25 01:35:05]

Yes, NOTREACHED() does nothing in non-debug builds, so we still need a return
statement in order for it to compile.

[liaoyuke, 2017/02/25 01:40:55]

I think it will compile even without this return, because this function always
returns something at the end. Could you please double-check?

[kkhorimoto, 2017/02/25 01:52:09]

It will compile, but it will return the wrong value.  If we allowed it to keep
going without an early return, the function will return the UA for
UserAgentType::MOBILE, which is not what was requested for the input parameter.

+  }
+
   // Using desktop user agent overrides a command-line user agent, so that
   // request desktop site can still work when using an overridden UA.
-  if (desktop_user_agent) {
+  if (type == web::UserAgentType::DESKTOP)
     return base::SysNSStringToUTF8(ChromeWebView::kDesktopUserAgent);
-  }
 
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kUserAgent)) {
     std::string user_agent =
         command_line->GetSwitchValueASCII(switches::kUserAgent);
     if (net::HttpUtil::IsValidHeaderValue(user_agent))
       return user_agent;
     LOG(WARNING) << "Ignored invalid value for flag --" << switches::kUserAgent;
   }
 
@@ skipping 51 matching lines @@
   // If this call fails, web will fall back to the default params.
   *params_vector =
       task_scheduler_util::GetBrowserWorkerPoolParamsFromVariations();
   *index_to_traits_callback =
       base::Bind(&task_scheduler_util::BrowserWorkerPoolIndexForTraits);
 }
 
 void ChromeWebClient::PerformExperimentalTaskSchedulerRedirections() {
   task_scheduler_util::MaybePerformBrowserTaskSchedulerRedirection();
 }