third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp - Issue 2705293010: PaymentApp: Implement respondWith() in PaymentRequestEvent. (blink side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp

Issue 2705293010: PaymentApp: Implement respondWith() in PaymentRequestEvent. (blink side) (Closed)

Patch Set: PaymentApp: Implement respondWith() in PaymentRequestEvent. (blink side) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/BUILD.gn ('k') | third_party/WebKit/Source/modules/payments/PaymentAppResponse.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp b/third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp

index abe0dd5bfc87237d34009d5a6fb62a45ba1a9ac0..864bae6fec843fb85d69d712c54d70f9c02f85d4 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp

@@ -86,7 +86,13 @@ PaymentMethodData toPaymentMethodData(

PaymentAppRequest PaymentAppRequestConversion::toPaymentAppRequest(

ScriptState* scriptState,

const WebPaymentAppRequest& webAppRequest) {

+ DCHECK(scriptState);

PaymentAppRequest appRequest;

+ if (!scriptState->contextIsValid())

+ return appRequest;

+ ScriptState::Scope scope(scriptState);

appRequest.setOrigin(webAppRequest.origin);

HeapVector<PaymentMethodData> methodData;