PaymentApp: Implement respondWith() in PaymentRequestEvent. (blink side)

third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentAppRequestConversion.h"
 
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ToV8.h"
 #include "modules/payments/PaymentAppRequest.h"
 #include "modules/payments/PaymentCurrencyAmount.h"
@@ skipping 69 matching lines @@
       stringDataToScriptValue(scriptState, webMethodData.stringifiedData));
   return methodData;
 }
 
 }  // namespace
 
 PaymentAppRequest PaymentAppRequestConversion::toPaymentAppRequest(
     ScriptState* scriptState,
     const WebPaymentAppRequest& webAppRequest) {
   PaymentAppRequest appRequest;
+  if (!scriptState || !scriptState->contextIsValid())

[haraken, 2017/03/14 16:15:51]

scriptState should not be null.

[zino, 2017/03/16 13:47:31]

Sorry, I don't understand exactly.
Did you mean that I have to use DCHECK instead of null check?
Or is it unncessary to check whether it is null?

[haraken, 2017/03/16 15:16:52]

Yeah, you can use DCHECK.

[zino, 2017/03/16 16:34:19]

Done.

+    return appRequest;
+
+  ScriptState::Scope scope(scriptState);
 
   appRequest.setOrigin(webAppRequest.origin);
   HeapVector<PaymentMethodData> methodData;
   for (const auto& md : webAppRequest.methodData) {
     methodData.push_back(toPaymentMethodData(scriptState, md));
   }
   appRequest.setMethodData(methodData);
   appRequest.setTotal(toPaymentItem(webAppRequest.total));
   HeapVector<PaymentDetailsModifier> modifiers;
   for (const auto& modifier : webAppRequest.modifiers) {
     modifiers.push_back(toPaymentDetailsModifier(scriptState, modifier));
   }
   appRequest.setOptionId(webAppRequest.optionId);
   return appRequest;
 }
 
 }  // namespace blink