Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: src/bootstrapper.cc

Issue 2705293004: Remove infrastructure for experimental JS natives (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/bootstrapper.h ('k') | src/debug/mirrors.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 8371955a437edd9c020d77771db12bdd4f2058ef..7936ac91ed5e10b49dc5b377b4ad658fc1ced2f1 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -57,8 +57,6 @@ Handle<String> Bootstrapper::SourceLookup(int index) {
template Handle<String> Bootstrapper::SourceLookup<Natives>(int index);
-template Handle<String> Bootstrapper::SourceLookup<ExperimentalNatives>(
- int index);
template Handle<String> Bootstrapper::SourceLookup<ExperimentalExtraNatives>(
int index);
template Handle<String> Bootstrapper::SourceLookup<ExtraNatives>(int index);
@@ -133,7 +131,6 @@ void DeleteNativeSources(Object* maybe_array) {
void Bootstrapper::TearDown() {
DeleteNativeSources(Natives::GetSourceCache(isolate_->heap()));
- DeleteNativeSources(ExperimentalNatives::GetSourceCache(isolate_->heap()));
DeleteNativeSources(ExtraNatives::GetSourceCache(isolate_->heap()));
DeleteNativeSources(
ExperimentalExtraNatives::GetSourceCache(isolate_->heap()));
@@ -230,7 +227,6 @@ class Genesis BASE_EMBEDDED {
void InstallTypedArray(const char* name, ElementsKind elements_kind,
Handle<JSFunction>* fun);
- bool InstallExperimentalNatives();
bool InstallExtraNatives();
bool InstallExperimentalExtraNatives();
bool InstallDebuggerNatives();
@@ -2950,19 +2946,6 @@ bool Bootstrapper::CompileBuiltin(Isolate* isolate, int index) {
}
-bool Bootstrapper::CompileExperimentalBuiltin(Isolate* isolate, int index) {
- HandleScope scope(isolate);
- Vector<const char> name = ExperimentalNatives::GetScriptName(index);
- Handle<String> source_code =
- isolate->bootstrapper()->SourceLookup<ExperimentalNatives>(index);
- Handle<Object> global = isolate->global_object();
- Handle<Object> utils = isolate->natives_utils_object();
- Handle<Object> args[] = {global, utils};
- return Bootstrapper::CompileNative(isolate, name, source_code,
- arraysize(args), args, NATIVES_CODE);
-}
-
-
bool Bootstrapper::CompileExtraBuiltin(Isolate* isolate, int index) {
HandleScope scope(isolate);
Vector<const char> name = ExtraNatives::GetScriptName(index);
@@ -4222,57 +4205,6 @@ bool Genesis::InstallNatives(GlobalContextType context_type) {
return true;
}
-
-bool Genesis::InstallExperimentalNatives() {
- static const char* harmony_tailcalls_natives[] = {nullptr};
- static const char* harmony_sharedarraybuffer_natives[] = {nullptr};
- static const char* harmony_do_expressions_natives[] = {nullptr};
- static const char* harmony_regexp_lookbehind_natives[] = {nullptr};
- static const char* harmony_regexp_named_captures_natives[] = {nullptr};
- static const char* harmony_regexp_property_natives[] = {nullptr};
- static const char* harmony_function_sent_natives[] = {nullptr};
- static const char* harmony_array_prototype_values_natives[] = {nullptr};
-#ifdef V8_I18N_SUPPORT
- static const char* icu_case_mapping_natives[] = {nullptr};
- static const char* datetime_format_to_parts_natives[] = {nullptr};
-#endif
- static const char* harmony_restrictive_generators_natives[] = {nullptr};
- static const char* harmony_trailing_commas_natives[] = {nullptr};
- static const char* harmony_function_tostring_natives[] = {nullptr};
- static const char* harmony_class_fields_natives[] = {nullptr};
- static const char* harmony_object_rest_spread_natives[] = {nullptr};
- static const char* harmony_async_iteration_natives[] = {nullptr};
- static const char* harmony_dynamic_import_natives[] = {nullptr};
- static const char* harmony_promise_finally_natives[] = {nullptr};
- static const char* harmony_template_escapes_natives[] = {nullptr};
-
- for (int i = ExperimentalNatives::GetDebuggerCount();
- i < ExperimentalNatives::GetBuiltinsCount(); i++) {
-#define INSTALL_EXPERIMENTAL_NATIVES(id, desc) \
- if (FLAG_##id) { \
- for (size_t j = 0; id##_natives[j] != NULL; j++) { \
- Vector<const char> script_name = ExperimentalNatives::GetScriptName(i); \
- if (strncmp(script_name.start(), id##_natives[j], \
- script_name.length()) == 0) { \
- if (!Bootstrapper::CompileExperimentalBuiltin(isolate(), i)) { \
- return false; \
- } \
- } \
- } \
- }
- HARMONY_INPROGRESS(INSTALL_EXPERIMENTAL_NATIVES);
- HARMONY_STAGED(INSTALL_EXPERIMENTAL_NATIVES);
- HARMONY_SHIPPING(INSTALL_EXPERIMENTAL_NATIVES);
-#undef INSTALL_EXPERIMENTAL_NATIVES
- }
-
- if (!CallUtilsFunction(isolate(), "PostExperimentals")) return false;
-
- InstallExperimentalBuiltinFunctionIds();
- return true;
-}
-
-
bool Genesis::InstallExtraNatives() {
HandleScope scope(isolate());
@@ -4304,7 +4236,7 @@ bool Genesis::InstallDebuggerNatives() {
for (int i = 0; i < Natives::GetDebuggerCount(); ++i) {
if (!Bootstrapper::CompileBuiltin(isolate(), i)) return false;
}
- return CallUtilsFunction(isolate(), "PostDebug");
+ return true;
}
@@ -4342,26 +4274,6 @@ void Genesis::InstallBuiltinFunctionIds() {
}
}
-
-void Genesis::InstallExperimentalBuiltinFunctionIds() {
- if (FLAG_harmony_sharedarraybuffer) {
- struct BuiltinFunctionIds {
- const char* holder_expr;
- const char* fun_name;
- BuiltinFunctionId id;
- };
-
- const BuiltinFunctionIds atomic_builtins[] = {
- ATOMIC_FUNCTIONS_WITH_ID_LIST(INSTALL_BUILTIN_ID)};
-
- for (const BuiltinFunctionIds& builtin : atomic_builtins) {
- Handle<JSObject> holder =
- ResolveBuiltinIdHolder(native_context(), builtin.holder_expr);
- InstallBuiltinFunctionId(holder, builtin.fun_name, builtin.id);
- }
- }
-}
-
#undef INSTALL_BUILTIN_ID
@@ -4871,7 +4783,6 @@ Genesis::Genesis(
if (context_type == FULL_CONTEXT) {
if (!isolate->serializer_enabled()) {
InitializeExperimentalGlobal();
- if (!InstallExperimentalNatives()) return;
if (FLAG_experimental_extras) {
if (!InstallExperimentalExtraNatives()) return;
@@ -4886,8 +4797,6 @@ Genesis::Genesis(
native_context()->set_string_function_prototype_map(
string_function_prototype->map());
}
- // The serializer cannot serialize typed arrays. Reset those typed arrays
- // for each new context.
} else if (context_type == DEBUG_CONTEXT) {
DCHECK(!isolate->serializer_enabled());
InitializeExperimentalGlobal();
« no previous file with comments | « src/bootstrapper.h ('k') | src/debug/mirrors.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698