Chromium Code Reviews| Index: test/cctest/heap/test-spaces.cc |
| diff --git a/test/cctest/heap/test-spaces.cc b/test/cctest/heap/test-spaces.cc |
| index fc692e331c3b1b4b6b2895493f54292d442c3539..ccee69efbc5b66f39b9f2830be9067ac80a18614 100644 |
| --- a/test/cctest/heap/test-spaces.cc |
| +++ b/test/cctest/heap/test-spaces.cc |
| @@ -530,8 +530,8 @@ TEST(SizeOfInitialHeap) { |
| // requires no extra space. |
|
adamk
2017/02/21 22:26:49
So this is unfortunate, but the existing test wasn
Yang
2017/02/22 09:38:14
Nice catch. I think the proposed change here is fi
adamk
2017/02/22 20:25:17
Okay. Hannes, need your LGTM for heap as well.
|
| CompileRun("/*empty*/"); |
| for (int i = FIRST_PAGED_SPACE; i <= LAST_PAGED_SPACE; i++) { |
| - // Debug code can be very large, so skip CODE_SPACE if we are generating it. |
| - if (i == CODE_SPACE && i::FLAG_debug_code) continue; |
| + // Skip CODE_SPACE, since we had to generate code even for an empty script. |
| + if (i == CODE_SPACE) continue; |
| CHECK_EQ(page_count[i], isolate->heap()->paged_space(i)->CountTotalPages()); |
| } |