Remove infrastructure for experimental JS natives

src/js/prologue.js

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils, extrasUtils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
 // -----------------------------------------------------------------------
 // Utils
 
 var imports = UNDEFINED;
-var imports_from_experimental = UNDEFINED;
 var exports_container = %ExportFromRuntime({});
-var typed_array_setup = UNDEFINED;
-
-// Register context value to be initialized with a typed array in
-// Genesis::InitializeBuiltinTypedArrays.
-function SetupTypedArray(f) {
-  f.next = typed_array_setup;
-  typed_array_setup = f;
-}
 
 // Export to other scripts.
-// In normal natives, this exports functions to other normal natives.
-// In experimental natives, this exports to other experimental natives and
-// to normal natives that import using utils.ImportFromExperimental.
 function Export(f) {
   f(exports_container);
 }
 
 
-// Import from other scripts. The actual importing happens in PostNatives and
-// PostExperimental so that we can import from scripts executed later. However,
-// that means that the import is not available until the very end. If the
-// import needs to be available immediate, use ImportNow.
-// In normal natives, this imports from other normal natives.
-// In experimental natives, this imports from other experimental natives and
-// whitelisted exports from normal natives.
+// Import from other scripts. The actual importing happens in PostNatives so
+// that we can import from scripts executed later. However, that means that
+// the import is not available until the very end. If the import needs to be
+// available immediately, use ImportNow.
 function Import(f) {
   f.next = imports;
   imports = f;
 }
 
 
 // Import immediately from exports of previous scripts. We need this for
 // functions called during bootstrapping. Hooking up imports in PostNatives
 // would be too late.
 function ImportNow(name) {
   return exports_container[name];
 }
 
 
-// In normal natives, import from experimental natives.
-// Not callable from experimental natives.
-function ImportFromExperimental(f) {
-  f.next = imports_from_experimental;
-  imports_from_experimental = f;
-}
-
-
 function SetFunctionName(f, name, prefix) {
   if (IS_SYMBOL(name)) {
     name = "[" + %SymbolDescription(name) + "]";
   }
   if (IS_UNDEFINED(prefix)) {
     %FunctionSetName(f, name);
   } else {
     %FunctionSetName(f, prefix + " " + name);
   }
 }
@@ skipping 84 matching lines @@
 // -----------------------------------------------------------------------
 // To be called by bootstrapper
 
 function PostNatives(utils) {
   %CheckIsBootstrapping();
 
   for ( ; !IS_UNDEFINED(imports); imports = imports.next) {
     imports(exports_container);
   }
 
-  // Whitelist of exports from normal natives to experimental natives and debug.
+  // Whitelist of exports from normal natives to debug natives.
   var expose_list = [
-    "FormatDateToParts",
     "MapEntries",
-    "MapIterator",
     "MapIteratorNext",
+    "SetIteratorNext",
+    "SetValues",

[Yang, 2017/02/22 09:38:14]

These functions could be pulled directly from Map.prototype and Set.prototype.
In the debug context, they are unpolluted.

[adamk, 2017/02/22 20:25:17]

Getting ahold of the .next methods isn't possible without allocating a Map and a
Set. That's what I've done now, but it looks a little funny.

+    // Exposed only for tests.

[adamk, 2017/02/21 22:26:49]

Sadly there are two mjsunit tests which test these things directly. It might
make sense to do something different in a followup patch but I've left them here
for simplicity.

     "MaxSimple",
     "MinSimple",
+    "MapIterator",
     "SetIterator",
-    "SetIteratorNext",
-    "SetValues",
-    "ToLocaleLowerCaseI18N",
-    "ToLocaleUpperCaseI18N",
-    "ToLowerCaseI18N",
-    "ToUpperCaseI18N",
-    // From runtime:
-    "promise_result_symbol",
-    "promise_state_symbol",
-    "reflect_apply",
-    "to_string_tag_symbol",
   ];
 
   var filtered_exports = {};
   %OptimizeObjectForAddingMultipleProperties(
       filtered_exports, expose_list.length);
   for (var key of expose_list) {
     filtered_exports[key] = exports_container[key];
   }
   %ToFastProperties(filtered_exports);
   exports_container = filtered_exports;
 
   utils.PostNatives = UNDEFINED;
-  utils.ImportFromExperimental = UNDEFINED;
 }
 
 
-function PostExperimentals(utils) {
-  %CheckIsBootstrapping();
-  for ( ; !IS_UNDEFINED(imports); imports = imports.next) {
-    imports(exports_container);
-  }
-  for ( ; !IS_UNDEFINED(imports_from_experimental);
-          imports_from_experimental = imports_from_experimental.next) {
-    imports_from_experimental(exports_container);
-  }
-
-  utils.Export = UNDEFINED;
-  utils.PostDebug = UNDEFINED;

[adamk, 2017/02/21 22:26:49]

I don't know if it was important for these to be set to UNDEFINED. If so, I can
add code in bootstrapper.cc to clear them out on the utils object from there
(without calling into script).

[Yang, 2017/02/22 09:38:14]

It should suffice to just move these over to PostNatives. We should also remove
PostDebug once possible.

You can also remove typed_array_setup and its use sites. It's no longer needed.

[adamk, 2017/02/22 20:25:17]

I can't do this in PostNatives since then the debugger context can't be set up
properly. Unless you're suggesting I just remove PostDebug as part of this
change. The latter is what I've done for now, let me know if this is what you
meant.
I think I already did (see the top of this file). Let me know if I'm missing
something.

-  utils.PostExperimentals = UNDEFINED;
-  typed_array_setup = UNDEFINED;
-}
-
-
 function PostDebug(utils) {
   for ( ; !IS_UNDEFINED(imports); imports = imports.next) {
     imports(exports_container);
   }
 
   exports_container = UNDEFINED;
 
   utils.Export = UNDEFINED;
   utils.Import = UNDEFINED;
   utils.ImportNow = UNDEFINED;
   utils.PostDebug = UNDEFINED;
-  utils.PostExperimentals = UNDEFINED;
-  typed_array_setup = UNDEFINED;
 }
 
 
-function InitializeBuiltinTypedArrays(utils, rng_state, rempio2result) {
-  var setup_list =  typed_array_setup;
-
-  for ( ; !IS_UNDEFINED(setup_list); setup_list = setup_list.next) {
-    setup_list(rng_state, rempio2result);
-  }
-}
-
-
 // -----------------------------------------------------------------------
 
 %OptimizeObjectForAddingMultipleProperties(utils, 14);
 
 utils.Import = Import;
 utils.ImportNow = ImportNow;
 utils.Export = Export;
-utils.ImportFromExperimental = ImportFromExperimental;
 utils.SetFunctionName = SetFunctionName;
 utils.InstallConstants = InstallConstants;
 utils.InstallFunctions = InstallFunctions;
 utils.InstallGetter = InstallGetter;
 utils.OverrideFunction = OverrideFunction;
 utils.SetUpLockedPrototype = SetUpLockedPrototype;
 utils.PostNatives = PostNatives;
-utils.PostExperimentals = PostExperimentals;
 utils.PostDebug = PostDebug;
 
 %ToFastProperties(utils);
 
 // -----------------------------------------------------------------------
 
 %OptimizeObjectForAddingMultipleProperties(extrasUtils, 7);
 
 extrasUtils.logStackTrace = function logStackTrace() {
   %DebugTrace();
@@ skipping 39 matching lines @@
   %promise_internal_reject(promise, reason, true);
 }
 
 extrasUtils.markPromiseAsHandled = function markPromiseAsHandled(promise) {
   %PromiseMarkAsHandled(promise);
 };
 
 %ToFastProperties(extrasUtils);
 
 })