Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4361)

Unified Diff: chrome/browser/download/download_history_unittest.cc

Issue 2705283003: Added last_access_time to DownloadItem and History DB (Closed)
Patch Set: Fix tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_history_unittest.cc
diff --git a/chrome/browser/download/download_history_unittest.cc b/chrome/browser/download/download_history_unittest.cc
index 24b1b4bf7c7e29a7cae11cce86e5aac03ba32fc5..506d3428a76e8dcf9ed30f751c6d5df9a1bfef11 100644
--- a/chrome/browser/download/download_history_unittest.cc
+++ b/chrome/browser/download/download_history_unittest.cc
@@ -235,7 +235,7 @@ class DownloadHistoryTest : public testing::Test {
history::ToContentDownloadState(row.state),
history::ToContentDownloadDangerType(row.danger_type),
history::ToContentDownloadInterruptReason(row.interrupt_reason),
- row.opened);
+ row.opened, row.last_access_time);
EXPECT_CALL(manager(), MockCreateDownloadItem(adapter))
.WillOnce(DoAll(
InvokeWithoutArgs(
@@ -346,8 +346,8 @@ class DownloadHistoryTest : public testing::Test {
(base::Time::Now() - base::TimeDelta::FromMinutes(1)), "Etag",
"abc", 100, 100, state,
content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- content::DOWNLOAD_INTERRUPT_REASON_NONE, false, std::string(),
- std::string(), info);
+ content::DOWNLOAD_INTERRUPT_REASON_NONE, false, base::Time::Now(),
+ std::string(), std::string(), info);
}
void InitItem(const std::string& guid,
@@ -371,6 +371,7 @@ class DownloadHistoryTest : public testing::Test {
content::DownloadDangerType danger_type,
content::DownloadInterruptReason interrupt_reason,
bool opened,
+ const base::Time& last_access_time,
const std::string& by_extension_id,
const std::string& by_extension_name,
history::DownloadRow* info) {
@@ -401,6 +402,7 @@ class DownloadHistoryTest : public testing::Test {
info->id = history::ToHistoryDownloadId(id);
info->guid = guid;
info->opened = opened;
+ info->last_access_time = last_access_time;
info->by_ext_id = by_extension_id;
info->by_ext_name = by_extension_name;
@@ -441,6 +443,8 @@ class DownloadHistoryTest : public testing::Test {
EXPECT_CALL(item(index), GetLastReason())
.WillRepeatedly(Return(interrupt_reason));
EXPECT_CALL(item(index), GetOpened()).WillRepeatedly(Return(opened));
+ EXPECT_CALL(item(index), GetLastAccessTime())
+ .WillRepeatedly(Return(last_access_time));
EXPECT_CALL(item(index), GetTargetDisposition())
.WillRepeatedly(
Return(content::DownloadItem::TARGET_DISPOSITION_OVERWRITE));

Powered by Google App Engine
This is Rietveld 408576698