Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2705283003: Added last_access_time to DownloadItem and History DB (Closed)
Patch Set: Fix tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index 3eacfd0dd893c5adee1cdb02496f47418e539ef1..06313d43c4d36e5c6c2a7bb75a3f5a128fb390f6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -1067,6 +1067,9 @@ public class DownloadManagerService extends BroadcastReceiver implements
/** See {@link #openDownloadedContent(Context, String, boolean, long)}. */
protected void openDownloadedContent(final DownloadInfo downloadInfo, final long downloadId) {
+ // TODO(shaktisahu): Move this to the broader openDownloadedContent() or a better place if
+ // possible.
+ updateLastAccessTime(downloadInfo.getDownloadGuid());
David Trainor- moved to gerrit 2017/02/22 05:56:03 Should this be in the postExecute of the broader c
shaktisahu 2017/02/23 06:55:47 Yes. I didn't find the download guid for all the c
openDownloadedContent(mContext, downloadInfo.getFilePath(),
isSupportedMimeType(downloadInfo.getMimeType()), downloadId);
}
@@ -1777,6 +1780,15 @@ public class DownloadManagerService extends BroadcastReceiver implements
return mAutoResumptionLimit;
}
+ /**
+ * Updates the last access time of a download.
+ * @param downloadGuid Download GUID.
+ */
+ @Override
+ public void updateLastAccessTime(String downloadGuid) {
+ nativeUpdateLastAccessTime(getNativeDownloadManagerService(), downloadGuid);
+ }
+
@Override
public void onMaxBandwidthChanged(double maxBandwidthMbps) {}
@@ -1809,4 +1821,6 @@ public class DownloadManagerService extends BroadcastReceiver implements
long nativeDownloadManagerService, boolean isOffTheRecord);
private native void nativeCheckForExternallyRemovedDownloads(
long nativeDownloadManagerService, boolean isOffTheRecord);
+ private native void nativeUpdateLastAccessTime(
+ long nativeDownloadManagerService, String downloadGuid);
}

Powered by Google App Engine
This is Rietveld 408576698