chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc - Issue 2705213002: Show different error message if ARC is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

Issue 2705213002: Show different error message if ARC is disabled. (Closed)

Patch Set: Fix browsertests and add a new test for 904 Arc Disabled Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h ('K') | « chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h ('k') | chrome/browser/chromeos/arc/auth/arc_manual_auth_code_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

diff --git a/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc b/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

index 62973cf22bb61c07c82731a9746023c71f506fec..197dffc24616b5db1022cd064f0b0fb9c15d79c3 100644

--- a/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

+++ b/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

@@ -182,7 +182,10 @@ void ArcBackgroundAuthCodeFetcher::ReportResult(

const std::string& auth_code,

OptInSilentAuthCode uma_status) {

UpdateSilentAuthCodeUMA(uma_status);

- base::ResetAndReturn(&callback_).Run(auth_code);

+ base::ResetAndReturn(&callback_)

+ .Run(auth_code.empty() ? ArcAuthInfoFetchStatus::FAILURE

+ : ArcAuthInfoFetchStatus::SUCCESS,

+ auth_code);

}

} // namespace arc