Cleanup the SVGTreeScopeResources interface

third_party/WebKit/Source/core/layout/svg/SVGResources.cpp

 /*
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 163 matching lines @@
 
 std::unique_ptr<SVGResources> SVGResources::buildResources(
     const LayoutObject* object,
     const ComputedStyle& computedStyle) {
   ASSERT(object);
 
   Node* node = object->node();
   ASSERT(node);
   SECURITY_DCHECK(node->isSVGElement());
 
-  SVGElement* element = toSVGElement(node);
-  ASSERT(element);
+  SVGElement& element = toSVGElement(*node);
 
-  const AtomicString& tagName = element->localName();
+  const AtomicString& tagName = element.localName();
   ASSERT(!tagName.isNull());
 
-  TreeScope& treeScope = element->treeScopeForIdResolution();
+  TreeScope& treeScope = element.treeScopeForIdResolution();
   SVGTreeScopeResources& treeScopeResources =
       treeScope.ensureSVGTreeScopedResources();
 
   const SVGComputedStyle& style = computedStyle.svgStyle();
 
   std::unique_ptr<SVGResources> resources;
   if (clipperFilterMaskerTags().contains(tagName)) {
     if (computedStyle.clipPath() && !object->isSVGRoot()) {
       ClipPathOperation* clipPathOperation = computedStyle.clipPath();
       if (clipPathOperation->type() == ClipPathOperation::REFERENCE) {
@@ skipping 27 matching lines @@
 
     if (style.hasMasker()) {
       AtomicString id = style.maskerResource();
       if (!ensureResources(resources).setMasker(
               getLayoutSVGResourceById<LayoutSVGResourceMasker>(
                   treeScopeResources, id)))
         treeScopeResources.addPendingResource(id, element);
     }
   }
 
-  if (style.hasMarkers() && supportsMarkers(*element)) {
+  if (style.hasMarkers() && supportsMarkers(element)) {
     const AtomicString& markerStartId = style.markerStartResource();
     if (!ensureResources(resources).setMarkerStart(
             getLayoutSVGResourceById<LayoutSVGResourceMarker>(
                 treeScopeResources, markerStartId)))
       treeScopeResources.addPendingResource(markerStartId, element);
 
     const AtomicString& markerMidId = style.markerMidResource();
     if (!ensureResources(resources).setMarkerMid(
             getLayoutSVGResourceById<LayoutSVGResourceMarker>(
                 treeScopeResources, markerMidId)))
@@ skipping 22 matching lines @@
       AtomicString id;
       LayoutSVGResourcePaintServer* resource = paintingResourceFromSVGPaint(
           treeScope, style.strokePaintType(), style.strokePaintUri(), id,
           hasPendingResource);
       if (!ensureResources(resources).setStroke(resource) && hasPendingResource)
         treeScopeResources.addPendingResource(id, element);
     }
   }
 
   if (chainableResourceTags().contains(tagName)) {
-    AtomicString id = targetReferenceFromResource(*element);
+    AtomicString id = targetReferenceFromResource(element);
     if (!ensureResources(resources).setLinkedResource(
             treeScopeResources.resourceById(id)))
       treeScopeResources.addPendingResource(id, element);
   }
 
   return (!resources || !resources->hasResourceData()) ? nullptr
                                                        : std::move(resources);
 }
 
 void SVGResources::layoutIfNeeded() {
@@ skipping 379 matching lines @@
               stroke->element());
   }
 
   if (m_linkedResource)
     fprintf(stderr, " |-> xlink:href : %p (node=%p)\n", m_linkedResource,
             m_linkedResource->element());
 }
 #endif
 
 }  // namespace blink