Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: src/builtins/builtins-regexp.cc

Issue 2705163005: [csa] Add Unreachable() and use it after throw sites (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-promise.cc ('k') | src/builtins/builtins-sharedarraybuffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-regexp.cc
diff --git a/src/builtins/builtins-regexp.cc b/src/builtins/builtins-regexp.cc
index 6d40ec6d00f790b950af45258eb2c1be24e7a4f0..a622ddfe28be60cb6dc056b0eeff725c07a3aeb0 100644
--- a/src/builtins/builtins-regexp.cc
+++ b/src/builtins/builtins-regexp.cc
@@ -398,8 +398,7 @@ Node* RegExpBuiltinsAssembler::ThrowIfNotJSReceiver(
CallRuntime(Runtime::kThrowTypeError, context, message_id, method_name_str,
value_str);
- var_value_map.Bind(UndefinedConstant());
- Goto(&out); // Never reached.
+ Unreachable();
}
Bind(&out);
@@ -1090,7 +1089,7 @@ void RegExpBuiltinsAssembler::FlagGetter(JSRegExp::Flag flag,
isolate->factory()->NewStringFromAsciiChecked(method_name));
CallRuntime(Runtime::kThrowTypeError, context, message_id,
method_name_str);
- Return(UndefinedConstant()); // Never reached.
+ Unreachable();
}
}
}
« no previous file with comments | « src/builtins/builtins-promise.cc ('k') | src/builtins/builtins-sharedarraybuffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698