media/gpu/OWNERS - Issue 2705153006: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/gpu/OWNERS

Issue 2705153006: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 dalecurtis@chromium.org	1 dalecurtis@chromium.org

2 posciak@chromium.org	2 posciak@chromium.org

3 sandersd@chromium.org	3 sandersd@chromium.org

4 wuchengli@chromium.org	4 wuchengli@chromium.org

5	5

6 # For Android media gpu files.	6 # For Android media gpu files.

7 per-file android=liberato@chromium.org	7 per-file android=liberato@chromium.org

8 per-file android=watk@chromium.org	8 per-file android=watk@chromium.org

9 per-file avda=liberato@chromium.org	9 per-file avda=liberato@chromium.org

10 per-file avda=watk@chromium.org	10 per-file avda=watk@chromium.org

11	11

12 per-file _messages.h=set noparent	12 per-file _messages.h=set noparent

13 per-file _messages.h=file://ipc/SECURITY_OWNERS	13 per-file _messages.h=file://ipc/SECURITY_OWNERS

	14

	15 # COMPONENT: Internals>GPU
	Pawel Osciak 2017/03/24 01:39:05 The component spanning all should probably be Inte The component spanning all should probably be Internals>Media>Video. However, for example for CrOS classes/files, OS>Kernel>Video would be preferred. Given that (per my understanding) we can have only one COMPONENT per OWNERS, we'd have to either split media/gpu into subdirectories, or manually triage from Internals>Media>Video. What would be preferable? ymzhang1 2017/03/24 16:43:39 Thanks for the comments! Yes, your understanding i Show quoted text On 2017/03/24 01:39:05, Pawel Osciak wrote: > The component spanning all should probably be Internals>Media>Video. However, > for example for CrOS classes/files, OS>Kernel>Video would be preferred. > > Given that (per my understanding) we can have only one COMPONENT per OWNERS, > we'd have to either split media/gpu into subdirectories, or manually triage from > Internals>Media>Video. > > What would be preferable? Thanks for the comments! Yes, your understanding is correct. Currently, I updated to Internals>Media>Video. Spliting media/gpu into subdirectories and adding proper components for them would be more helpful. It is actually a better choice if it doesn't break current codes. DaleCurtis 2017/03/27 18:53:54 Adding platform specific subdirs sgtm, we already Show quoted text On 2017/03/24 at 16:43:39, ymzhang1 wrote: > On 2017/03/24 01:39:05, Pawel Osciak wrote: > > The component spanning all should probably be Internals>Media>Video. However, > > for example for CrOS classes/files, OS>Kernel>Video would be preferred. > > > > Given that (per my understanding) we can have only one COMPONENT per OWNERS, > > we'd have to either split media/gpu into subdirectories, or manually triage from > > Internals>Media>Video. > > > > What would be preferable? > > Thanks for the comments! Yes, your understanding is correct. Currently, I updated to Internals>Media>Video. > > Spliting media/gpu into subdirectories and adding proper components for them would be more helpful. It is actually a better choice if it doesn't break current codes. Adding platform specific subdirs sgtm, we already do this for media/audio/{mac,win,linux,android,cras}
OLD	NEW

« no previous file with comments | « media/capture/video/linux/OWNERS ('k') | third_party/libva/OWNERS » ('j') | third_party/libva/OWNERS » ('J')