Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2705143002: Split StyleSurroundData::offset into separate members. (Closed)
Patch Set: Fix typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index a53868d5208a2a2d950d3bc3f2f1dc5cc91b81b5..ce181590e397b542416a4be2f8b245d245992bf2 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -542,7 +542,7 @@ StyleDifference ComputedStyle::visualInvalidationDiff(
}
if (!diff.needsFullLayout() && position() != EPosition::kStatic &&
- m_surround->offset != other.m_surround->offset) {
+ !offsetEqual(other)) {
// Optimize for the case where a positioned layer is moving but not changing
// size.
if (dependenceOnContentHeightHasChanged(*this, other))
@@ -594,8 +594,7 @@ bool ComputedStyle::scrollAnchorDisablingPropertyChanged(
}
if (m_surround.get() != other.m_surround.get()) {
- if (m_surround->margin != other.m_surround->margin ||
- m_surround->offset != other.m_surround->offset ||
+ if (m_surround->margin != other.m_surround->margin || !offsetEqual(other) ||
m_surround->padding != other.m_surround->padding)
return true;
}
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/StyleSurroundData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698