Split StyleSurroundData::offset into separate members.

third_party/WebKit/Source/platform/LengthBox.h

 /*
     Copyright (C) 1999 Lars Knoll (knoll@kde.org)
     Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
     Copyright (c) 2012, Google Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
 
@@ skipping 50 matching lines @@
   const Length& logicalLeft(WritingMode) const;
   const Length& logicalRight(WritingMode) const;
 
   const Length& before(WritingMode) const;
   const Length& after(WritingMode) const;
   const Length& start(WritingMode, TextDirection) const;
   const Length& end(WritingMode, TextDirection) const;
   const Length& over(WritingMode) const;
   const Length& under(WritingMode) const;
 
+  // For use in ComputedStyle.h
+  // TODO(shend): these are independent of LengthBox, make them nonmember

[nainar, 2017/02/21 02:28:37]

could that be done in this patch? Having these functions here seems a bit off to
me

+  // functions.
+  static const Length& logicalLeft(WritingMode,
+                                   const Length& left,
+                                   const Length& top);
+  static const Length& logicalRight(WritingMode,
+                                    const Length& right,
+                                    const Length& bottom);
+  static const Length& before(WritingMode,
+                              const Length& top,
+                              const Length& left,
+                              const Length& right);
+  static const Length& after(WritingMode,
+                             const Length& bottom,
+                             const Length& left,
+                             const Length& right);
+
   bool operator==(const LengthBox& o) const {
     return m_left == o.m_left && m_right == o.m_right && m_top == o.m_top &&
            m_bottom == o.m_bottom;
   }
 
   bool operator!=(const LengthBox& o) const { return !(*this == o); }
 
   bool nonZero() const {
     return !(m_left.isZero() && m_right.isZero() && m_top.isZero() &&
              m_bottom.isZero());
   }
 
   // Must be public for SET_VAR in ComputedStyle.h
   Length m_left;
   Length m_right;
   Length m_top;
   Length m_bottom;
 };
 
 }  // namespace blink
 
 #endif  // LengthBox_h