Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2377)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 2705113005: Update AutoImport to import nothing by default (in absence of policy and master_prefs). (Closed)
Patch Set: review:grt#7 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index cef77d36b5d63da541ff25c222c5acbd520eda61..61499a3e06bddd9d2a67fa028ef13652f9146f07 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -262,37 +262,43 @@ namespace {
#if BUILDFLAG(ENABLE_GOOGLE_NOW)
// Deprecated 3/2016
-const char kGoogleGeolocationAccessEnabled[] =
+constexpr char kGoogleGeolocationAccessEnabled[] =
"googlegeolocationaccess.enabled";
#endif
// Deprecated 4/2016.
-const char kCheckDefaultBrowser[] = "browser.check_default_browser";
+constexpr char kCheckDefaultBrowser[] = "browser.check_default_browser";
// Deprecated 5/2016.
-const char kDesktopSearchRedirectionInfobarShownPref[] =
+constexpr char kDesktopSearchRedirectionInfobarShownPref[] =
"desktop_search_redirection_infobar_shown";
// Deprecated 7/2016.
-const char kNetworkPredictionEnabled[] = "dns_prefetching.enabled";
-const char kDisableSpdy[] = "spdy.disabled";
+constexpr char kNetworkPredictionEnabled[] = "dns_prefetching.enabled";
+constexpr char kDisableSpdy[] = "spdy.disabled";
// Deprecated 8/2016.
-const char kRecentlySelectedEncoding[] = "profile.recently_selected_encodings";
-const char kStaticEncodings[] = "intl.static_encodings";
+constexpr char kRecentlySelectedEncoding[] = "profile.recently_selected_encodings";
+constexpr char kStaticEncodings[] = "intl.static_encodings";
// Deprecated 9/2016.
-const char kWebKitUsesUniversalDetector[] =
+constexpr char kWebKitUsesUniversalDetector[] =
"webkit.webprefs.uses_universal_detector";
-const char kWebKitAllowDisplayingInsecureContent[] =
+constexpr char kWebKitAllowDisplayingInsecureContent[] =
"webkit.webprefs.allow_displaying_insecure_content";
#if BUILDFLAG(ENABLE_EXTENSIONS)
// Deprecated 2/2017.
-const char kToolbarMigratedComponentActionStatus[] =
+constexpr char kToolbarMigratedComponentActionStatus[] =
"toolbar_migrated_component_action_status";
#endif
+// master_preferences used to be mapped as-is to Preferences on first run but
+// the "distribution" dictionary was never used beyond first run. It is now
+// stripped in first_run.cc prior to applying this mapping. Cleanup for existing
+// Preferences files added here 2/2017.
+constexpr char kDistroDict[] = "distribution";
+
void DeleteWebRTCIdentityStoreDBOnFileThread(
const base::FilePath& profile_path) {
base::DeleteFile(profile_path.Append(
@@ -640,6 +646,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
#if BUILDFLAG(ENABLE_EXTENSIONS)
registry->RegisterDictionaryPref(kToolbarMigratedComponentActionStatus);
#endif
+
+ registry->RegisterDictionaryPref(kDistroDict);
}
void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
@@ -732,6 +740,9 @@ void MigrateObsoleteProfilePrefs(Profile* profile) {
// Added 2/2017.
profile_prefs->ClearPref(kToolbarMigratedComponentActionStatus);
#endif
+
+ // Added 2/2017.
+ profile_prefs->ClearPref(kDistroDict);
grt (UTC plus 2) 2017/02/23 21:19:01 can't do this because of PingDelay :-(
gab 2017/02/23 23:27:53 Fixed in precursor CL.
}
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698