Update AutoImport to import nothing by default (in absence of policy and master_prefs).

chrome/installer/util/master_preferences_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Unit tests for master preferences related methods.
 
 #include "chrome/installer/util/master_preferences.h"
 
 #include <stddef.h>
 
@@ skipping 57 matching lines @@
   EXPECT_TRUE(base::DeleteFile(prefs_file(), false));
   installer::MasterPreferences prefs(prefs_file());
   EXPECT_FALSE(prefs.read_from_file());
 }
 
 TEST_F(MasterPreferencesTest, ParseDistroParams) {
   const char text[] =
       "{ \n"
       "  \"distribution\": { \n"
       "     \"show_welcome_page\": true,\n"
-      "     \"import_search_engine\": true,\n"
-      "     \"import_history\": true,\n"
-      "     \"import_bookmarks\": true,\n"
       "     \"import_bookmarks_from_file\": \"c:\\\\foo\",\n"
-      "     \"import_home_page\": true,\n"
       "     \"welcome_page_on_os_upgrade_enabled\": true,\n"
       "     \"do_not_create_any_shortcuts\": true,\n"
       "     \"do_not_create_desktop_shortcut\": true,\n"
       "     \"do_not_create_quick_launch_shortcut\": true,\n"
       "     \"do_not_create_taskbar_shortcut\": true,\n"
       "     \"do_not_launch_chrome\": true,\n"
       "     \"make_chrome_default\": true,\n"
       "     \"make_chrome_default_for_user\": true,\n"
       "     \"system_level\": true,\n"
       "     \"verbose_logging\": true,\n"
       "     \"require_eula\": true\n"
       "  },\n"
       "  \"blah\": {\n"
-      "     \"import_history\": false\n"
+      "     \"show_welcome_page\": false\n"
       "  }\n"
       "} \n";
 
   EXPECT_TRUE(base::WriteFile(prefs_file(), text,
                               static_cast<int>(strlen(text))));
   installer::MasterPreferences prefs(prefs_file());
   EXPECT_TRUE(prefs.read_from_file());
 
   const char* const expected_true[] = {
-      installer::master_preferences::kDistroImportSearchPref,
-      installer::master_preferences::kDistroImportHistoryPref,
-      installer::master_preferences::kDistroImportBookmarksPref,
-      installer::master_preferences::kDistroImportHomePagePref,
       installer::master_preferences::kDistroWelcomePageOnOSUpgradeEnabled,
       installer::master_preferences::kDoNotCreateAnyShortcuts,
       installer::master_preferences::kDoNotCreateDesktopShortcut,
       installer::master_preferences::kDoNotCreateQuickLaunchShortcut,
       installer::master_preferences::kDoNotCreateTaskbarShortcut,
       installer::master_preferences::kDoNotLaunchChrome,
       installer::master_preferences::kMakeChromeDefault,
       installer::master_preferences::kMakeChromeDefaultForUser,
       installer::master_preferences::kSystemLevel,
       installer::master_preferences::kVerboseLogging,
       installer::master_preferences::kRequireEula,
   };
 
   for (size_t i = 0; i < arraysize(expected_true); ++i) {
     bool value = false;
     EXPECT_TRUE(prefs.GetBool(expected_true[i], &value));
     EXPECT_TRUE(value) << expected_true[i];
   }
 
   std::string str_value;
   EXPECT_TRUE(prefs.GetString(
       installer::master_preferences::kDistroImportBookmarksFromFilePref,
       &str_value));
   EXPECT_STREQ("c:\\foo", str_value.c_str());
 }
 
 TEST_F(MasterPreferencesTest, ParseMissingDistroParams) {
   const char text[] =
-    "{ \n"
-    "  \"distribution\": { \n"
-    "     \"import_search_engine\": true,\n"
-    "     \"import_bookmarks\": false,\n"
-    "     \"import_bookmarks_from_file\": \"\",\n"
-    "     \"do_not_create_desktop_shortcut\": true,\n"
-    "     \"do_not_create_quick_launch_shortcut\": true,\n"
-    "     \"do_not_launch_chrome\": true\n"
-    "  }\n"
-    "} \n";
+      "{ \n"
+      "  \"distribution\": { \n"
+      "     \"import_bookmarks_from_file\": \"\",\n"
+      "     \"do_not_create_desktop_shortcut\": true,\n"
+      "     \"do_not_create_quick_launch_shortcut\": true,\n"
+      "     \"do_not_launch_chrome\": false\n"
+      "  }\n"
+      "} \n";
 
   EXPECT_TRUE(base::WriteFile(prefs_file(), text,
                               static_cast<int>(strlen(text))));
   installer::MasterPreferences prefs(prefs_file());
   EXPECT_TRUE(prefs.read_from_file());
 
   ExpectedBooleans expected_bool[] = {
-    { installer::master_preferences::kDistroImportSearchPref, true },
-    { installer::master_preferences::kDistroImportBookmarksPref, false },
-    { installer::master_preferences::kDoNotCreateDesktopShortcut, true },
-    { installer::master_preferences::kDoNotCreateQuickLaunchShortcut, true },
-    { installer::master_preferences::kDoNotLaunchChrome, true },
+      {installer::master_preferences::kDoNotCreateDesktopShortcut, true},
+      {installer::master_preferences::kDoNotCreateQuickLaunchShortcut, true},
+      {installer::master_preferences::kDoNotLaunchChrome, false},
   };
 
   bool value = false;
   for (size_t i = 0; i < arraysize(expected_bool); ++i) {
     EXPECT_TRUE(prefs.GetBool(expected_bool[i].name, &value));
     EXPECT_EQ(value, expected_bool[i].expected_value) << expected_bool[i].name;
   }
 
   const char* const missing_bools[] = {
-    installer::master_preferences::kDistroImportHomePagePref,
     installer::master_preferences::kDistroWelcomePageOnOSUpgradeEnabled,
     installer::master_preferences::kDoNotRegisterForUpdateLaunch,
     installer::master_preferences::kMakeChromeDefault,
     installer::master_preferences::kMakeChromeDefaultForUser,
   };
 
   for (size_t i = 0; i < arraysize(missing_bools); ++i) {
     EXPECT_FALSE(prefs.GetBool(missing_bools[i], &value)) << missing_bools[i];
   }
 
@@ skipping 131 matching lines @@
       base::CommandLine::FromString(chrome_cmd.str()));
 
   installer::MasterPreferences pref_chrome(chrome_install);
 }
 
 TEST_F(MasterPreferencesTest, EnforceLegacyPreferences) {
   static const char kLegacyPrefs[] =
       "{"
       "  \"distribution\": {"
       "     \"create_all_shortcuts\": false,\n"
+      "     \"import_bookmarks\": true,\n"
+      "     \"import_history\": true,\n"
+      "     \"import_home_page\": true,\n"
+      "     \"import_search_engine\": true,\n"
       "     \"ping_delay\": 40\n"
       "  }"
       "}";
 
   installer::MasterPreferences prefs(kLegacyPrefs);
 
   bool do_not_create_desktop_shortcut = false;
   bool do_not_create_quick_launch_shortcut = false;
   bool do_not_create_taskbar_shortcut = false;
   prefs.GetBool(installer::master_preferences::kDoNotCreateDesktopShortcut,
                 &do_not_create_desktop_shortcut);
   prefs.GetBool(installer::master_preferences::kDoNotCreateQuickLaunchShortcut,
                 &do_not_create_quick_launch_shortcut);
   prefs.GetBool(installer::master_preferences::kDoNotCreateTaskbarShortcut,
                 &do_not_create_taskbar_shortcut);
   // create_all_shortcuts is a legacy preference that should only enforce
   // do_not_create_desktop_shortcut and do_not_create_quick_launch_shortcut
   // when set to false.
   EXPECT_TRUE(do_not_create_desktop_shortcut);
   EXPECT_TRUE(do_not_create_quick_launch_shortcut);
   EXPECT_FALSE(do_not_create_taskbar_shortcut);
 
+  bool actual_value = false;
+  EXPECT_TRUE(prefs.master_dictionary().GetBoolean(prefs::kImportBookmarks,
+                                                   &actual_value));
+  EXPECT_TRUE(actual_value);
+  EXPECT_TRUE(prefs.master_dictionary().GetBoolean(prefs::kImportHistory,
+                                                   &actual_value));
+  EXPECT_TRUE(actual_value);
+  EXPECT_TRUE(prefs.master_dictionary().GetBoolean(prefs::kImportHomepage,
+                                                   &actual_value));
+  EXPECT_TRUE(actual_value);
+  EXPECT_TRUE(prefs.master_dictionary().GetBoolean(prefs::kImportSearchEngine,
+                                                   &actual_value));
+  EXPECT_TRUE(actual_value);
+
 #if BUILDFLAG(ENABLE_RLZ)
   int rlz_ping_delay = 0;
   EXPECT_TRUE(prefs.master_dictionary().GetInteger(prefs::kRlzPingDelaySeconds,
                                                    &rlz_ping_delay));
   EXPECT_EQ(40, rlz_ping_delay);
 #endif  // BUILDFLAG(ENABLE_RLZ)
 }
 
 TEST_F(MasterPreferencesTest, DontEnforceLegacyCreateAllShortcutsTrue) {
   static const char kCreateAllShortcutsFalsePrefs[] =
@@ skipping 76 matching lines @@
   }
   {
     ScopedGoogleUpdateIsMachine env_setter("2");
     installer::MasterPreferences prefs(
         base::CommandLine(base::FilePath(FILE_PATH_LITERAL("setup.exe"))));
     bool value = false;
     prefs.GetBool(installer::master_preferences::kSystemLevel, &value);
     EXPECT_FALSE(value);
   }
 }