Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/installer/util/master_preferences_unittest.cc

Issue 2705113005: Update AutoImport to import nothing by default (in absence of policy and master_prefs). (Closed)
Patch Set: review:grt#7 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Unit tests for master preferences related methods. 5 // Unit tests for master preferences related methods.
6 6
7 #include "chrome/installer/util/master_preferences.h" 7 #include "chrome/installer/util/master_preferences.h"
8 8
9 #include <stddef.h> 9 #include <stddef.h>
10 10
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 EXPECT_TRUE(base::DeleteFile(prefs_file(), false)); 67 EXPECT_TRUE(base::DeleteFile(prefs_file(), false));
68 installer::MasterPreferences prefs(prefs_file()); 68 installer::MasterPreferences prefs(prefs_file());
69 EXPECT_FALSE(prefs.read_from_file()); 69 EXPECT_FALSE(prefs.read_from_file());
70 } 70 }
71 71
72 TEST_F(MasterPreferencesTest, ParseDistroParams) { 72 TEST_F(MasterPreferencesTest, ParseDistroParams) {
73 const char text[] = 73 const char text[] =
74 "{ \n" 74 "{ \n"
75 " \"distribution\": { \n" 75 " \"distribution\": { \n"
76 " \"show_welcome_page\": true,\n" 76 " \"show_welcome_page\": true,\n"
77 " \"import_search_engine\": true,\n"
78 " \"import_history\": true,\n"
79 " \"import_bookmarks\": true,\n"
80 " \"import_bookmarks_from_file\": \"c:\\\\foo\",\n" 77 " \"import_bookmarks_from_file\": \"c:\\\\foo\",\n"
81 " \"import_home_page\": true,\n"
82 " \"welcome_page_on_os_upgrade_enabled\": true,\n" 78 " \"welcome_page_on_os_upgrade_enabled\": true,\n"
83 " \"do_not_create_any_shortcuts\": true,\n" 79 " \"do_not_create_any_shortcuts\": true,\n"
84 " \"do_not_create_desktop_shortcut\": true,\n" 80 " \"do_not_create_desktop_shortcut\": true,\n"
85 " \"do_not_create_quick_launch_shortcut\": true,\n" 81 " \"do_not_create_quick_launch_shortcut\": true,\n"
86 " \"do_not_create_taskbar_shortcut\": true,\n" 82 " \"do_not_create_taskbar_shortcut\": true,\n"
87 " \"do_not_launch_chrome\": true,\n" 83 " \"do_not_launch_chrome\": true,\n"
88 " \"make_chrome_default\": true,\n" 84 " \"make_chrome_default\": true,\n"
89 " \"make_chrome_default_for_user\": true,\n" 85 " \"make_chrome_default_for_user\": true,\n"
90 " \"system_level\": true,\n" 86 " \"system_level\": true,\n"
91 " \"verbose_logging\": true,\n" 87 " \"verbose_logging\": true,\n"
92 " \"require_eula\": true,\n" 88 " \"require_eula\": true,\n"
93 " \"ping_delay\": 40\n" 89 " \"ping_delay\": 40\n"
94 " },\n" 90 " },\n"
95 " \"blah\": {\n" 91 " \"blah\": {\n"
96 " \"import_history\": false\n" 92 " \"show_welcome_page\": false\n"
97 " }\n" 93 " }\n"
98 "} \n"; 94 "} \n";
99 95
100 EXPECT_TRUE(base::WriteFile(prefs_file(), text, 96 EXPECT_TRUE(base::WriteFile(prefs_file(), text,
101 static_cast<int>(strlen(text)))); 97 static_cast<int>(strlen(text))));
102 installer::MasterPreferences prefs(prefs_file()); 98 installer::MasterPreferences prefs(prefs_file());
103 EXPECT_TRUE(prefs.read_from_file()); 99 EXPECT_TRUE(prefs.read_from_file());
104 100
105 const char* const expected_true[] = { 101 const char* const expected_true[] = {
106 installer::master_preferences::kDistroImportSearchPref,
107 installer::master_preferences::kDistroImportHistoryPref,
108 installer::master_preferences::kDistroImportBookmarksPref,
109 installer::master_preferences::kDistroImportHomePagePref,
110 installer::master_preferences::kDistroWelcomePageOnOSUpgradeEnabled, 102 installer::master_preferences::kDistroWelcomePageOnOSUpgradeEnabled,
111 installer::master_preferences::kDoNotCreateAnyShortcuts, 103 installer::master_preferences::kDoNotCreateAnyShortcuts,
112 installer::master_preferences::kDoNotCreateDesktopShortcut, 104 installer::master_preferences::kDoNotCreateDesktopShortcut,
113 installer::master_preferences::kDoNotCreateQuickLaunchShortcut, 105 installer::master_preferences::kDoNotCreateQuickLaunchShortcut,
114 installer::master_preferences::kDoNotCreateTaskbarShortcut, 106 installer::master_preferences::kDoNotCreateTaskbarShortcut,
115 installer::master_preferences::kDoNotLaunchChrome, 107 installer::master_preferences::kDoNotLaunchChrome,
116 installer::master_preferences::kMakeChromeDefault, 108 installer::master_preferences::kMakeChromeDefault,
117 installer::master_preferences::kMakeChromeDefaultForUser, 109 installer::master_preferences::kMakeChromeDefaultForUser,
118 installer::master_preferences::kSystemLevel, 110 installer::master_preferences::kSystemLevel,
119 installer::master_preferences::kVerboseLogging, 111 installer::master_preferences::kVerboseLogging,
(...skipping 15 matching lines...) Expand all
135 int ping_delay = 90; 127 int ping_delay = 90;
136 EXPECT_TRUE(prefs.GetInt(installer::master_preferences::kDistroPingDelay, 128 EXPECT_TRUE(prefs.GetInt(installer::master_preferences::kDistroPingDelay,
137 &ping_delay)); 129 &ping_delay));
138 EXPECT_EQ(ping_delay, 40); 130 EXPECT_EQ(ping_delay, 40);
139 } 131 }
140 132
141 TEST_F(MasterPreferencesTest, ParseMissingDistroParams) { 133 TEST_F(MasterPreferencesTest, ParseMissingDistroParams) {
142 const char text[] = 134 const char text[] =
143 "{ \n" 135 "{ \n"
144 " \"distribution\": { \n" 136 " \"distribution\": { \n"
145 " \"import_search_engine\": true,\n"
146 " \"import_bookmarks\": false,\n"
147 " \"import_bookmarks_from_file\": \"\",\n" 137 " \"import_bookmarks_from_file\": \"\",\n"
148 " \"do_not_create_desktop_shortcut\": true,\n" 138 " \"do_not_create_desktop_shortcut\": true,\n"
149 " \"do_not_create_quick_launch_shortcut\": true,\n" 139 " \"do_not_create_quick_launch_shortcut\": true,\n"
150 " \"do_not_launch_chrome\": true\n" 140 " \"do_not_launch_chrome\": false\n"
151 " }\n" 141 " }\n"
152 "} \n"; 142 "} \n";
153 143
154 EXPECT_TRUE(base::WriteFile(prefs_file(), text, 144 EXPECT_TRUE(base::WriteFile(prefs_file(), text,
155 static_cast<int>(strlen(text)))); 145 static_cast<int>(strlen(text))));
156 installer::MasterPreferences prefs(prefs_file()); 146 installer::MasterPreferences prefs(prefs_file());
157 EXPECT_TRUE(prefs.read_from_file()); 147 EXPECT_TRUE(prefs.read_from_file());
158 148
159 ExpectedBooleans expected_bool[] = { 149 ExpectedBooleans expected_bool[] = {
160 { installer::master_preferences::kDistroImportSearchPref, true },
161 { installer::master_preferences::kDistroImportBookmarksPref, false },
162 { installer::master_preferences::kDoNotCreateDesktopShortcut, true }, 150 { installer::master_preferences::kDoNotCreateDesktopShortcut, true },
163 { installer::master_preferences::kDoNotCreateQuickLaunchShortcut, true }, 151 { installer::master_preferences::kDoNotCreateQuickLaunchShortcut, true },
164 { installer::master_preferences::kDoNotLaunchChrome, true }, 152 { installer::master_preferences::kDoNotLaunchChrome, false },
165 }; 153 };
166 154
167 bool value = false; 155 bool value = false;
168 for (size_t i = 0; i < arraysize(expected_bool); ++i) { 156 for (size_t i = 0; i < arraysize(expected_bool); ++i) {
169 EXPECT_TRUE(prefs.GetBool(expected_bool[i].name, &value)); 157 EXPECT_TRUE(prefs.GetBool(expected_bool[i].name, &value));
170 EXPECT_EQ(value, expected_bool[i].expected_value) << expected_bool[i].name; 158 EXPECT_EQ(value, expected_bool[i].expected_value) << expected_bool[i].name;
171 } 159 }
172 160
173 const char* const missing_bools[] = { 161 const char* const missing_bools[] = {
174 installer::master_preferences::kDistroImportHomePagePref,
175 installer::master_preferences::kDistroWelcomePageOnOSUpgradeEnabled, 162 installer::master_preferences::kDistroWelcomePageOnOSUpgradeEnabled,
176 installer::master_preferences::kDoNotRegisterForUpdateLaunch, 163 installer::master_preferences::kDoNotRegisterForUpdateLaunch,
177 installer::master_preferences::kMakeChromeDefault, 164 installer::master_preferences::kMakeChromeDefault,
178 installer::master_preferences::kMakeChromeDefaultForUser, 165 installer::master_preferences::kMakeChromeDefaultForUser,
179 }; 166 };
180 167
181 for (size_t i = 0; i < arraysize(missing_bools); ++i) { 168 for (size_t i = 0; i < arraysize(missing_bools); ++i) {
182 EXPECT_FALSE(prefs.GetBool(missing_bools[i], &value)) << missing_bools[i]; 169 EXPECT_FALSE(prefs.GetBool(missing_bools[i], &value)) << missing_bools[i];
183 } 170 }
184 171
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 } 421 }
435 { 422 {
436 ScopedGoogleUpdateIsMachine env_setter("2"); 423 ScopedGoogleUpdateIsMachine env_setter("2");
437 installer::MasterPreferences prefs( 424 installer::MasterPreferences prefs(
438 base::CommandLine(base::FilePath(FILE_PATH_LITERAL("setup.exe")))); 425 base::CommandLine(base::FilePath(FILE_PATH_LITERAL("setup.exe"))));
439 bool value = false; 426 bool value = false;
440 prefs.GetBool(installer::master_preferences::kSystemLevel, &value); 427 prefs.GetBool(installer::master_preferences::kSystemLevel, &value);
441 EXPECT_FALSE(value); 428 EXPECT_FALSE(value);
442 } 429 }
443 } 430 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698