Update AutoImport to import nothing by default (in absence of policy and master_prefs).

chrome/browser/ui/browser_ui_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_ui_prefs.h"
 
 #include "build/build_config.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
@@ skipping 53 matching lines @@
       prefs::kEnableTranslate,
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterStringPref(prefs::kCloudPrintEmail, std::string());
   registry->RegisterBooleanPref(prefs::kCloudPrintProxyEnabled, true);
   registry->RegisterBooleanPref(prefs::kCloudPrintSubmitEnabled, true);
   registry->RegisterBooleanPref(prefs::kDevToolsDisabled, false);
   registry->RegisterDictionaryPref(prefs::kBrowserWindowPlacement);
   registry->RegisterDictionaryPref(prefs::kBrowserWindowPlacementPopup);
   registry->RegisterDictionaryPref(prefs::kAppWindowPlacement);
-  registry->RegisterBooleanPref(prefs::kImportAutofillFormData, true);
-  registry->RegisterBooleanPref(prefs::kImportBookmarks, true);
-  registry->RegisterBooleanPref(prefs::kImportHistory, true);
-  registry->RegisterBooleanPref(prefs::kImportHomepage, true);
-  registry->RegisterBooleanPref(prefs::kImportSavedPasswords, true);
-  registry->RegisterBooleanPref(prefs::kImportSearchEngine, true);
+  registry->RegisterBooleanPref(prefs::kImportAutofillFormData, false);

[grt (UTC plus 2), 2017/02/23 14:05:48]

this will cause all checkboxes in chrome://settings/importData to be unchecked
by default, no? i don't think this is the right thing.

[gab, 2017/02/23 20:37:40]

Right, I'd seen those and initially thought it made sense for them to reflect
what was imported on first run but you now make me realize that having these all
unchecked by default is not great.

Also, I thought it was merely reading the value without setting it back but now
I realize I just happen to know nothing about webUI: it's actually hooked up to
the pref (and toggles the actual pref live when using the UI) :
https://cs.chromium.org/search/?q=(%22%7C%27)import_history(%22%7C%27)&sq=pac...
(I think the import_data_overlay.html bit is the critical hook).

Thinking about this some more, I don't think it makes sense for this UI to be
driven by policies for the same pref as auto import... I don't even know that it
makes sense for it to be driven by policies at all? That would mean that a
policy could prevent import even if the user explicitly wants to tick that box?

+ewald, can you look into this?

+  registry->RegisterBooleanPref(prefs::kImportBookmarks, false);
+  registry->RegisterBooleanPref(prefs::kImportHistory, false);
+  registry->RegisterBooleanPref(prefs::kImportHomepage, false);
+  registry->RegisterBooleanPref(prefs::kImportSavedPasswords, false);
+  registry->RegisterBooleanPref(prefs::kImportSearchEngine, false);
   registry->RegisterBooleanPref(
       prefs::kEnableDoNotTrack,
       false,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 #if BUILDFLAG(ENABLE_WEBRTC)
   // TODO(guoweis): Remove next 2 options at M50.
   registry->RegisterBooleanPref(prefs::kWebRTCMultipleRoutesEnabled, true);
   registry->RegisterBooleanPref(prefs::kWebRTCNonProxiedUdpEnabled, true);
   registry->RegisterStringPref(prefs::kWebRTCIPHandlingPolicy,
                                content::kWebRTCIPHandlingDefault);
@@ skipping 31 matching lines @@
   registry->RegisterBooleanPref(
       prefs::kHideFullscreenToolbar,
       false,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 #else
   registry->RegisterBooleanPref(prefs::kFullscreenAllowed, true);
 #endif
 }
 
 }  // namespace chrome