Chromium Code Reviews| Index: content/renderer/pepper/pepper_video_decoder_host.cc |
| diff --git a/content/renderer/pepper/pepper_video_decoder_host.cc b/content/renderer/pepper/pepper_video_decoder_host.cc |
| index ca396610d343f63d611f69cbea5d73671f9f16dc..3aea65f00caebf154c86a8251d8038752ba5ac67 100644 |
| --- a/content/renderer/pepper/pepper_video_decoder_host.cc |
| +++ b/content/renderer/pepper/pepper_video_decoder_host.cc |
| @@ -204,13 +204,10 @@ int32_t PepperVideoDecoderHost::OnHostMsgGetShm( |
| base::SharedMemoryHandle shm_handle = shm->handle(); |
| if (shm_id == shm_buffers_.size()) { |
| - shm_buffers_.push_back(shm.release()); |
| + shm_buffers_.push_back(std::move(shm)); |
| shm_buffer_busy_.push_back(false); |
| } else { |
| - // Remove the old buffer. Delete manually since ScopedVector won't delete |
| - // the existing element if we just assign over it. |
|
Avi (use Gerrit)
2017/02/21 16:01:36
Holy cow, this comment is correct. I thought that
|
| - delete shm_buffers_[shm_id]; |
| - shm_buffers_[shm_id] = shm.release(); |
| + shm_buffers_[shm_id] = std::move(shm); |
| } |
| SerializedHandle handle( |