Issue 270503006: Make pseudo-classes selector queries work on DocumentFragment

Issue 270503006: Make pseudo-classes selector queries work on DocumentFragment (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
esprehn, dglazkov

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof, tasak

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make pseudo-classes selector queries work on DocumentFragment Make pseudo-classes selector queries work on DocumentFragment as well. This CL extends tasak@'s r167322 to cover all DocumentFragment nodes, and not only the ShadowRoot. This was made easier by esprehn@'s r169787 which made the corresponding code more shareable. The new behavior is consistent with Firefox 28. R=esprehn@chromium.org, dglazkov@chromium.org BUG=355386 TEST=fast/dom/DocumentFragment/sibling-rules-under-document-fragment.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174095

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address Esprehn's comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -12 lines)			Patch
A	LayoutTests/fast/dom/DocumentFragment/sibling-rules-under-document-fragment.html	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/DocumentFragment/sibling-rules-under-document-fragment-expected.txt	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	1	10 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/dom/ContainerNode.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/dom/Node.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

esprehn

This patch is not correct as is, you changed a bunch of stuff related to ...

6 years, 7 months ago (2014-05-08 05:25:11 UTC) #2

Inactive

https://codereview.chromium.org/270503006/diff/1/LayoutTests/fast/dom/DocumentFragment/sibling-rules-under-document-fragment.html File LayoutTests/fast/dom/DocumentFragment/sibling-rules-under-document-fragment.html (right): https://codereview.chromium.org/270503006/diff/1/LayoutTests/fast/dom/DocumentFragment/sibling-rules-under-document-fragment.html#newcode3 LayoutTests/fast/dom/DocumentFragment/sibling-rules-under-document-fragment.html:3: <head> On 2014/05/08 05:25:11, esprehn wrote: > We usually ...

6 years, 7 months ago (2014-05-08 13:17:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/270503006/20001

6 years, 7 months ago (2014-05-15 15:50:23 UTC) #6

Message was sent while issue was closed.

Change committed as 174095

Expand Messages | Collapse Messages