Add fast --HEAD option to upstream-diff.

Add fast --HEAD option to upstream-diff.

This is useful for large repos (like src.git)

R=agable@chromium.org, szager@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269079

[agable, 2014-05-07 00:57:48]

LGTM % two nits.

https://codereview.chromium.org/270503003/diff/1/git_upstream_diff.py
File git_upstream_diff.py (right):

https://codereview.chromium.org/270503003/diff/1/git_upstream_diff.py#newcode23
git_upstream_diff.py:23: help=('Diff against HEAD instead of the working copy.'
No space between this period and 'Much...'

https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.txt
File man/src/git-upstream-diff.txt (right):

https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.tx...
man/src/git-upstream-diff.txt:44: --HEAD::
Not sure how I feel about the flag being capitalized. Does argparse enforce case
sensitivity for long-form flags? HEAD makes sense from a git perspective, but
capitalized long-form flags are really rare.

[iannucci, 2014-05-07 01:02:23]

https://codereview.chromium.org/270503003/diff/1/git_upstream_diff.py
File git_upstream_diff.py (right):

https://codereview.chromium.org/270503003/diff/1/git_upstream_diff.py#newcode23
git_upstream_diff.py:23: help=('Diff against HEAD instead of the working copy.'
On 2014/05/07 00:57:48, agable wrote:
> No space between this period and 'Much...'

Good catch. Done.

https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.txt
File man/src/git-upstream-diff.txt (right):

https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.tx...
man/src/git-upstream-diff.txt:44: --HEAD::
On 2014/05/07 00:57:48, agable wrote:
> Not sure how I feel about the flag being capitalized. Does argparse enforce
case
> sensitivity for long-form flags? HEAD makes sense from a git perspective, but
> capitalized long-form flags are really rare.

Hm, but I don't think `--head` would make sense either.... What do you suggest?

[szager1, 2014-05-07 06:48:31]

lgtm with nit

https://codereview.chromium.org/270503003/diff/1/man/html/git-upstream-diff.html
File man/html/git-upstream-diff.html (right):

https://codereview.chromium.org/270503003/diff/1/man/html/git-upstream-diff.h...
man/html/git-upstream-diff.html:814: uncommitted changes.
unstaged and uncommitted changes.

https://codereview.chromium.org/270503003/diff/1/man/man1/git-upstream-diff.1
File man/man1/git-upstream-diff.1 (right):

https://codereview.chromium.org/270503003/diff/1/man/man1/git-upstream-diff.1...
man/man1/git-upstream-diff.1:74: faster on large repos, but doesn\(cqt take into
account uncommitted changes\&.
unstaged and uncommitted

https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.txt
File man/src/git-upstream-diff.txt (right):

https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.tx...
man/src/git-upstream-diff.txt:47: uncommitted changes.
unstaged and uncommitted

[iannucci, 2014-05-07 07:36:04]

On 2014/05/07 06:48:31, szager1 wrote:
> lgtm with nit
> 
>
https://codereview.chromium.org/270503003/diff/1/man/html/git-upstream-diff.html
> File man/html/git-upstream-diff.html (right):
> 
>
https://codereview.chromium.org/270503003/diff/1/man/html/git-upstream-diff.h...
> man/html/git-upstream-diff.html:814: uncommitted changes.
> unstaged and uncommitted changes.
> 
> https://codereview.chromium.org/270503003/diff/1/man/man1/git-upstream-diff.1
> File man/man1/git-upstream-diff.1 (right):
> 
>
https://codereview.chromium.org/270503003/diff/1/man/man1/git-upstream-diff.1...
> man/man1/git-upstream-diff.1:74: faster on large repos, but doesn\(cqt take
into
> account uncommitted changes\&.
> unstaged and uncommitted
> 
> https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.txt
> File man/src/git-upstream-diff.txt (right):
> 
>
https://codereview.chromium.org/270503003/diff/1/man/src/git-upstream-diff.tx...
> man/src/git-upstream-diff.txt:47: uncommitted changes.
> unstaged and uncommitted

Actually it's just 'uncommitted'. I could do it v. --cached though and then it
would be 'unstaged and uncommitted' changes. That may be a good idea. I guess in
that event, I don't need to add any more parsed options to this tool, just
document the fact that passing --cached to the normal version will do the right
thing.

[iannucci, 2014-05-07 07:48:08]

PTAL. Best code is no code :)

[agable, 2014-05-07 22:43:18]

LGTM. Maybe note that this is simply passed through, so someone looking at the
code doesn't get super confused.

[iannucci, 2014-05-08 19:16:59]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-05-08 19:18:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/iannucci@chromium.org/270503003/20001

[commit-bot: I haz the power, 2014-05-08 19:20:11]

Change committed as 269079